| Message ID | 1525043888-90983-1-git-send-email-mjc@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/29/2018 04:18 PM, Michael Clark wrote: > This fixes an issue when disassembling rv128 c.sqsp, > where the code erroneously fell through to c.swsp. > > Cc: Palmer Dabbelt <palmer@sifive.com> > Cc: Sagar Karandikar <sagark@eecs.berkeley.edu> > Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> > Cc: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Michael Clark <mjc@sifive.com> > --- > disas/riscv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 04/29/2018 08:18 PM, Michael Clark wrote: > This fixes an issue when disassembling rv128 c.sqsp, > where the code erroneously fell through to c.swsp. > > Cc: Palmer Dabbelt <palmer@sifive.com> > Cc: Sagar Karandikar <sagark@eecs.berkeley.edu> > Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> > Cc: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Michael Clark <mjc@sifive.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > disas/riscv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/disas/riscv.c b/disas/riscv.c > index 74ad16eacdd3..ea19f6fbe2b1 100644 > --- a/disas/riscv.c > +++ b/disas/riscv.c > @@ -1470,8 +1470,9 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa isa) > if (isa == rv128) { > op = rv_op_c_sqsp; > } else { > - op = rv_op_c_fsdsp; break; > + op = rv_op_c_fsdsp; > } > + break; > case 6: op = rv_op_c_swsp; break; > case 7: > if (isa == rv32) { >
diff --git a/disas/riscv.c b/disas/riscv.c index 74ad16eacdd3..ea19f6fbe2b1 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@ -1470,8 +1470,9 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa isa) if (isa == rv128) { op = rv_op_c_sqsp; } else { - op = rv_op_c_fsdsp; break; + op = rv_op_c_fsdsp; } + break; case 6: op = rv_op_c_swsp; break; case 7: if (isa == rv32) {
This fixes an issue when disassembling rv128 c.sqsp, where the code erroneously fell through to c.swsp. Cc: Palmer Dabbelt <palmer@sifive.com> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Clark <mjc@sifive.com> --- disas/riscv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)