| Message ID | 1525682614-3824-31-git-send-email-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On 07.05.2018 11:43, Ajay Singh wrote: > Cleanup patch to have variable names as per linux coding style. > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > --- > drivers/staging/wilc1000/host_interface.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > index ad9270e..e27010c 100644 > --- a/drivers/staging/wilc1000/host_interface.c > +++ b/drivers/staging/wilc1000/host_interface.c > @@ -1543,7 +1543,7 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key) > struct wid wid; > struct wid wid_list[5]; > u8 *key_buf; > - s8 s8idxarray[1]; > + s8 idxarray[1]; > struct host_if_drv *hif_drv = vif->hif_drv; > > switch (hif_key->type) { > @@ -1610,8 +1610,8 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key) > wid.id = (u16)WID_REMOVE_WEP_KEY; > wid.type = WID_STR; > > - s8idxarray[0] = (s8)hif_key->attr.wep.index; > - wid.val = s8idxarray; > + idxarray[0] = (s8)hif_key->attr.wep.index; I think you can get rid of idxarray at all. > + wid.val = idxarray;> wid.size = 1; > > result = wilc_send_config_pkt(vif, SET_CFG, >
On Wed, 9 May 2018 16:42:20 +0300 Claudiu Beznea <Claudiu.Beznea@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Cleanup patch to have variable names as per linux coding style. > > > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > > --- > > drivers/staging/wilc1000/host_interface.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/wilc1000/host_interface.c > > b/drivers/staging/wilc1000/host_interface.c index ad9270e..e27010c > > 100644 --- a/drivers/staging/wilc1000/host_interface.c > > +++ b/drivers/staging/wilc1000/host_interface.c > > @@ -1543,7 +1543,7 @@ static int handle_key(struct wilc_vif *vif, > > struct key_attr *hif_key) struct wid wid; > > struct wid wid_list[5]; > > u8 *key_buf; > > - s8 s8idxarray[1]; > > + s8 idxarray[1]; > > struct host_if_drv *hif_drv = vif->hif_drv; > > > > switch (hif_key->type) { > > @@ -1610,8 +1610,8 @@ static int handle_key(struct wilc_vif *vif, > > struct key_attr *hif_key) wid.id = (u16)WID_REMOVE_WEP_KEY; > > wid.type = WID_STR; > > > > - s8idxarray[0] = > > (s8)hif_key->attr.wep.index; > > - wid.val = s8idxarray; > > + idxarray[0] = > > (s8)hif_key->attr.wep.index; > > I think you can get rid of idxarray at all. > Yes, we can remove idxarray variable. I will update and resubmit this patch. > > + wid.val = idxarray;> > > wid.size = 1; > > result = wilc_send_config_pkt(vif, SET_CFG, > >
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index ad9270e..e27010c 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -1543,7 +1543,7 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key) struct wid wid; struct wid wid_list[5]; u8 *key_buf; - s8 s8idxarray[1]; + s8 idxarray[1]; struct host_if_drv *hif_drv = vif->hif_drv; switch (hif_key->type) { @@ -1610,8 +1610,8 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key) wid.id = (u16)WID_REMOVE_WEP_KEY; wid.type = WID_STR; - s8idxarray[0] = (s8)hif_key->attr.wep.index; - wid.val = s8idxarray; + idxarray[0] = (s8)hif_key->attr.wep.index; + wid.val = idxarray; wid.size = 1; result = wilc_send_config_pkt(vif, SET_CFG,
Cleanup patch to have variable names as per linux coding style. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)