diff mbox

ndctl: remove warning caused by -D_FORTIFY_SOURCE=2 and -O0 compile flags

Message ID 152605735888.60453.10483504271205064345.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dave Jiang May 11, 2018, 4:49 p.m. UTC
Compiler spits out warning with -D_FORTIFY_SOURCE=2 and -O0. Moving to -O2
to remove warnings.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---

-v2: Add -O2 option to configure.ac as well. (Vishal)

 README.md    |    2 +-
 autogen.sh   |    2 +-
 configure.ac |    3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Verma, Vishal L May 11, 2018, 6:02 p.m. UTC | #1
On Fri, 2018-05-11 at 09:49 -0700, Dave Jiang wrote:
> Compiler spits out warning with -D_FORTIFY_SOURCE=2 and -O0. Moving to
> -O2
> to remove warnings.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> 
> -v2: Add -O2 option to configure.ac as well. (Vishal)

Thanks for the update, applied.

> 
>  README.md    |    2 +-
>  autogen.sh   |    2 +-
>  configure.ac |    3 ++-
>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/README.md b/README.md
> index 899dcbb8..e0bc5b7b 100644
> --- a/README.md
> +++ b/README.md
> @@ -6,7 +6,7 @@ sub-system in the Linux kernel
>  Build
>  =====
>  `./autogen.sh`  
> -`./configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --
> libdir=/usr/lib64`  
> +`./configure CFLAGS='-g -O2' --prefix=/usr --sysconfdir=/etc --
> libdir=/usr/lib64`  
>  `make`  
>  `make check`  
>  `sudo make install`  
> diff --git a/autogen.sh b/autogen.sh
> index a23cf53c..2a52688b 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -24,5 +24,5 @@ echo "-------------------------------------------------
> ---------------"
>  echo "Initialized build system. For a common configuration please run:"
>  echo "----------------------------------------------------------------"
>  echo
> -echo "./configure CFLAGS='-g -O0' $args"
> +echo "./configure CFLAGS='-g -O2' $args"
>  echo
> diff --git a/configure.ac b/configure.ac
> index 6dbfcee8..a1e4e837 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -149,7 +149,8 @@ my_CFLAGS="\
>  -Wtype-limits \
>  -Wmaybe-uninitialized \
>  -Wunused-result \
> --D_FORTIFY_SOURCE=2
> +-D_FORTIFY_SOURCE=2 \
> +-O2
>  "
>  AC_SUBST([my_CFLAGS])
>  
>
diff mbox

Patch

diff --git a/README.md b/README.md
index 899dcbb8..e0bc5b7b 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@  sub-system in the Linux kernel
 Build
 =====
 `./autogen.sh`  
-`./configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib64`  
+`./configure CFLAGS='-g -O2' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib64`  
 `make`  
 `make check`  
 `sudo make install`  
diff --git a/autogen.sh b/autogen.sh
index a23cf53c..2a52688b 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -24,5 +24,5 @@  echo "----------------------------------------------------------------"
 echo "Initialized build system. For a common configuration please run:"
 echo "----------------------------------------------------------------"
 echo
-echo "./configure CFLAGS='-g -O0' $args"
+echo "./configure CFLAGS='-g -O2' $args"
 echo
diff --git a/configure.ac b/configure.ac
index 6dbfcee8..a1e4e837 100644
--- a/configure.ac
+++ b/configure.ac
@@ -149,7 +149,8 @@  my_CFLAGS="\
 -Wtype-limits \
 -Wmaybe-uninitialized \
 -Wunused-result \
--D_FORTIFY_SOURCE=2
+-D_FORTIFY_SOURCE=2 \
+-O2
 "
 AC_SUBST([my_CFLAGS])