| Message ID | 1526472723-15758-2-git-send-email-arend.vanspriel@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f8793c26fe586659d6da3fa277e63961a69d314b |
| Delegated to: | Kalle Valo |
| Headers | show |
Arend van Spriel <arend.vanspriel@broadcom.com> writes: > The only user of ALLFFMAC is the flowring module so no need to > expose it in a header file. > > Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com> > Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> > Reviewed-by: Franky Lin <franky.lin@broadcom.com> > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> > --- > Hi Kalle, > > I recall Joe Perches posted patches dealing with broadcast address declarations, > but don't know what happened with those. In patchwork [1] is says 'Not Applicable' > whatever that means. I noticed Johannes set similar mac80211 change to > 'Awaiting Upstream'. Anyway, when applying this patch the patch in [1] needs to > be reworked. > > Regards, > Arend > > [1] https://patchwork.kernel.org/patch/10318857/ 'Not Applicable' means that I have assumed that the patch is not suitable for my tree for whatever reason, I guess in this case because it was part of a bigger patchset.
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote: > The only user of ALLFFMAC is the flowring module so no need to > expose it in a header file. > > Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com> > Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> > Reviewed-by: Franky Lin <franky.lin@broadcom.com> > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> 6 patches applied to wireless-drivers-next.git, thanks. f8793c26fe58 brcmfmac: move ALLFFMAC variable in flowring module 8e072168f75e brcmfmac: add support for sysfs initiated coredump 21c5c83ce833 mwifiex: support sysfs initiated device coredump d2af9b566554 brcmfmac: validate user provided data for memdump before copying 8a3ab2f38f16 brcmfmac: trigger memory dump upon firmware halt signal b8248236e927 brcmfmac: trigger memory dump on SDIO firmware halt message
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index 105b877..cd36510 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -36,8 +36,6 @@ MODULE_DESCRIPTION("Broadcom 802.11 wireless LAN fullmac driver."); MODULE_LICENSE("Dual BSD/GPL"); -const u8 ALLFFMAC[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; - #define BRCMF_DEFAULT_SCAN_CHANNEL_TIME 40 #define BRCMF_DEFAULT_SCAN_UNASSOC_TIME 40 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h index ef91461..a34642c 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h @@ -19,8 +19,6 @@ #include <linux/platform_data/brcmfmac.h> #include "fwil_types.h" -extern const u8 ALLFFMAC[ETH_ALEN]; - #define BRCMF_FW_ALTPATH_LEN 256 /* Definitions for the module global and device specific settings are defined diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c index d0b738d..d0d8b32 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c @@ -46,6 +46,8 @@ 3 }; +static const u8 ALLFFMAC[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; + static bool brcmf_flowring_is_tdls_mac(struct brcmf_flowring *flow, u8 mac[ETH_ALEN])