diff mbox

[for-rc,1/4] RDMA/hns: Bugfix for cq record db for kernel

Message ID 1526638497-97031-2-git-send-email-oulijun@huawei.com (mailing list archive)
State Superseded
Headers show

Commit Message

Lijun Ou May 18, 2018, 10:14 a.m. UTC
When use cq record db for kernel, it nees to set the hr_cq->db_en
to 1 and configure the dma address of record cq db of qp context.

Fixes: 887b4b9("RDMA/hns: Support cq record doorbell for kernel space")

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 drivers/infiniband/hw/hns/hns_roce_cq.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Leon Romanovsky May 22, 2018, 5:59 a.m. UTC | #1
On Fri, May 18, 2018 at 06:14:54PM +0800, Lijun Ou wrote:
> When use cq record db for kernel, it nees to set the hr_cq->db_en

nees --> needs

> to 1 and configure the dma address of record cq db of qp context.
>
> Fixes: 887b4b9("RDMA/hns: Support cq record doorbell for kernel space")
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>

No extra space, please.

> ---
>  drivers/infiniband/hw/hns/hns_roce_cq.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_cq.c b/drivers/infiniband/hw/hns/hns_roce_cq.c
> index 14734d0..3a485f5 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_cq.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_cq.c
> @@ -377,6 +377,7 @@ struct ib_cq *hns_roce_ib_create_cq(struct ib_device *ib_dev,
>
>  			hr_cq->set_ci_db = hr_cq->db.db_record;
>  			*hr_cq->set_ci_db = 0;
> +			hr_cq->db_en = 1;
>  		}
>
>  		/* Init mmt table and write buff address to mtt table */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lijun Ou May 22, 2018, 11:42 a.m. UTC | #2
在 2018/5/22 13:59, Leon Romanovsky 写道:
> On Fri, May 18, 2018 at 06:14:54PM +0800, Lijun Ou wrote:
>> When use cq record db for kernel, it nees to set the hr_cq->db_en
> 
> nees --> needs
> 
>> to 1 and configure the dma address of record cq db of qp context.
>>
>> Fixes: 887b4b9("RDMA/hns: Support cq record doorbell for kernel space")
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> 
> No extra space, please.
> 
thanks, I will fixes it.
>> ---
>>  drivers/infiniband/hw/hns/hns_roce_cq.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/infiniband/hw/hns/hns_roce_cq.c b/drivers/infiniband/hw/hns/hns_roce_cq.c
>> index 14734d0..3a485f5 100644
>> --- a/drivers/infiniband/hw/hns/hns_roce_cq.c
>> +++ b/drivers/infiniband/hw/hns/hns_roce_cq.c
>> @@ -377,6 +377,7 @@ struct ib_cq *hns_roce_ib_create_cq(struct ib_device *ib_dev,
>>
>>  			hr_cq->set_ci_db = hr_cq->db.db_record;
>>  			*hr_cq->set_ci_db = 0;
>> +			hr_cq->db_en = 1;
>>  		}
>>
>>  		/* Init mmt table and write buff address to mtt table */
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_cq.c b/drivers/infiniband/hw/hns/hns_roce_cq.c
index 14734d0..3a485f5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_cq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_cq.c
@@ -377,6 +377,7 @@  struct ib_cq *hns_roce_ib_create_cq(struct ib_device *ib_dev,
 
 			hr_cq->set_ci_db = hr_cq->db.db_record;
 			*hr_cq->set_ci_db = 0;
+			hr_cq->db_en = 1;
 		}
 
 		/* Init mmt table and write buff address to mtt table */