diff mbox

wireless-regdb: Fix iteration in create_wmms() for python 3

Message ID 20180518171725.28828-1-seth.forshee@canonical.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Seth Forshee May 18, 2018, 5:17 p.m. UTC 
The iteration in this function is over countries.itervalues(),
which is not compatible with python 3. Switch to iterating over
contries.values() instead.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
 db2fw.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee May 25, 2018, 4:34 p.m. UTC | #1 
On Fri, May 18, 2018 at 12:17:25PM -0500, Seth Forshee wrote:
> The iteration in this function is over countries.itervalues(),
> which is not compatible with python 3. Switch to iterating over
> contries.values() instead.
> 
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>

Applied.
diff mbox

Patch

diff --git a/db2fw.py b/db2fw.py
index 269325604ea3..0c0f030c0c63 100755
--- a/db2fw.py
+++ b/db2fw.py
@@ -29,7 +29,7 @@  def create_collections(countries):
 
 def create_wmms(countries):
     result = {}
-    for c in countries.itervalues():
+    for c in countries.values():
         for rule in c.permissions:
             if rule.wmmrule is not None:
                 result[rule.wmmrule] = 1