diff mbox

[1/2] b43legacy: report core number

Message ID 20110726153648.24611.49190.stgit@mj.roinet.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Pavel Roskin July 26, 2011, 3:36 p.m. UTC
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 0 files changed, 0 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Larry Finger July 26, 2011, 3:57 p.m. UTC | #1
On 07/26/2011 10:36 AM, Pavel Roskin wrote:
> Signed-off-by: Pavel Roskin<proski@gnu.org>
> ---
>   0 files changed, 0 insertions(+), 0 deletions(-)

Very informative diffstat! :)

>
> diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
> index ffa4671..224991a 100644
> --- a/drivers/net/wireless/b43legacy/main.c
> +++ b/drivers/net/wireless/b43legacy/main.c
> @@ -3785,7 +3785,8 @@ static int b43legacy_wireless_init(struct ssb_device *dev)
>   	INIT_WORK(&wl->beacon_update_trigger, b43legacy_beacon_update_trigger_work);
>
>   	ssb_set_devtypedata(dev, wl);
> -	b43legacyinfo(wl, "Broadcom %04X WLAN found\n", dev->bus->chip_id);
> +	b43legacyinfo(wl, "Broadcom %04X WLAN found (core revision %u)\n",
> +		      dev->bus->chip_id, dev->id.revision);
>   	err = 0;
>   out:
>   	return err;

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pavel Roskin July 26, 2011, 4:08 p.m. UTC | #2
On 07/26/2011 11:57 AM, Larry Finger wrote:
> On 07/26/2011 10:36 AM, Pavel Roskin wrote:
>> Signed-off-by: Pavel Roskin<proski@gnu.org>
>> ---
>> 0 files changed, 0 insertions(+), 0 deletions(-)
>
> Very informative diffstat! :)

That happens if "stg mail" is run from a directory that is not above the 
changed files.  I'll try to get it fixed.

Thanks for the quick review!
Kalle Valo Aug. 3, 2011, 3:55 p.m. UTC | #3
Pavel Roskin <proski@gnu.org> writes:

>>> 0 files changed, 0 insertions(+), 0 deletions(-)
>>
>> Very informative diffstat! :)
>
> That happens if "stg mail" is run from a directory that is not above
> the changed files.  I'll try to get it fixed.

Is stgit still alive? I haven't seen a release for a long time.
Pavel Roskin Aug. 3, 2011, 6:26 p.m. UTC | #4
On 08/03/2011 11:55 AM, Kalle Valo wrote:
> Pavel Roskin<proski@gnu.org>  writes:
>
>>>> 0 files changed, 0 insertions(+), 0 deletions(-)
>>>
>>> Very informative diffstat! :)
>>
>> That happens if "stg mail" is run from a directory that is not above
>> the changed files.  I'll try to get it fixed.
>
> Is stgit still alive? I haven't seen a release for a long time.

I hate to go too far offtopic, but anyway, StGIT is pretty much usable, 
even though it's not under active development anymore.
diff mbox

Patch

diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
index ffa4671..224991a 100644
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -3785,7 +3785,8 @@  static int b43legacy_wireless_init(struct ssb_device *dev)
 	INIT_WORK(&wl->beacon_update_trigger, b43legacy_beacon_update_trigger_work);
 
 	ssb_set_devtypedata(dev, wl);
-	b43legacyinfo(wl, "Broadcom %04X WLAN found\n", dev->bus->chip_id);
+	b43legacyinfo(wl, "Broadcom %04X WLAN found (core revision %u)\n",
+		      dev->bus->chip_id, dev->id.revision);
 	err = 0;
 out:
 	return err;