| Message ID | 153254813164.92573.10755585465477668768.stgit@bhelgaas-glaptop.roam.corp.google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: Remove unnecessary includes of <linux/pci-aspm.h> | expand |
On 7/25/2018 12:52 PM, Bjorn Helgaas wrote: > emove includes of <linux/pci-aspm.h> from files that don't need > it. I'll apply all these via the PCI tree unless there's objection. > > --- > > Bjorn Helgaas (4): > igb: Remove unnecessary include of <linux/pci-aspm.h> > ath9k: Remove unnecessary include of <linux/pci-aspm.h> > iwlwifi: Remove unnecessary include of <linux/pci-aspm.h> > PCI: Remove unnecessary include of <linux/pci-aspm.h> Thanks. Reviewed-by: Sinan Kaya <okaya@kernel.org> Is it possible to kill that file altogether? I haven't looked who is using outside of pci directory.
On Wed, Jul 25, 2018 at 01:33:23PM -0700, Sinan Kaya wrote: > On 7/25/2018 12:52 PM, Bjorn Helgaas wrote: > > emove includes of <linux/pci-aspm.h> from files that don't need > > it. I'll apply all these via the PCI tree unless there's objection. > > > > --- > > > > Bjorn Helgaas (4): > > igb: Remove unnecessary include of <linux/pci-aspm.h> > > ath9k: Remove unnecessary include of <linux/pci-aspm.h> > > iwlwifi: Remove unnecessary include of <linux/pci-aspm.h> > > PCI: Remove unnecessary include of <linux/pci-aspm.h> > > Thanks. > > Reviewed-by: Sinan Kaya <okaya@kernel.org> > > Is it possible to kill that file altogether? I haven't looked who is > using outside of pci directory. Thanks for taking a look! It's possible we could remove it altogether; there's very little in it, and in most cases the only reason drivers include it is to disable certain ASPM link states to work around hardware defects. It might make sense to just move that interface into <linux/pci.h>.
On Wed, Jul 25, 2018 at 02:52:08PM -0500, Bjorn Helgaas wrote: > Remove includes of <linux/pci-aspm.h> from files that don't need > it. I'll apply all these via the PCI tree unless there's objection. > > --- > > Bjorn Helgaas (4): > igb: Remove unnecessary include of <linux/pci-aspm.h> > ath9k: Remove unnecessary include of <linux/pci-aspm.h> > iwlwifi: Remove unnecessary include of <linux/pci-aspm.h> > PCI: Remove unnecessary include of <linux/pci-aspm.h> > > > drivers/net/ethernet/intel/igb/igb_main.c | 1 - > drivers/net/wireless/ath/ath9k/pci.c | 1 - > drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 - > drivers/pci/pci-sysfs.c | 1 - > drivers/pci/pci.c | 1 - > drivers/pci/probe.c | 1 - > drivers/pci/remove.c | 1 - > 7 files changed, 7 deletions(-) I applied these to the pci/aspm branch for v4.19.
Remove includes of <linux/pci-aspm.h> from files that don't need it. I'll apply all these via the PCI tree unless there's objection. --- Bjorn Helgaas (4): igb: Remove unnecessary include of <linux/pci-aspm.h> ath9k: Remove unnecessary include of <linux/pci-aspm.h> iwlwifi: Remove unnecessary include of <linux/pci-aspm.h> PCI: Remove unnecessary include of <linux/pci-aspm.h> drivers/net/ethernet/intel/igb/igb_main.c | 1 - drivers/net/wireless/ath/ath9k/pci.c | 1 - drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 - drivers/pci/pci-sysfs.c | 1 - drivers/pci/pci.c | 1 - drivers/pci/probe.c | 1 - drivers/pci/remove.c | 1 - 7 files changed, 7 deletions(-)