| Message ID | 20180806121451.GA14954@embeddedor.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ASoC: wm8994: Fix missing break in switch | expand |
On Mon, Aug 06, 2018 at 07:14:51AM -0500, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to the default case. > > Cc: stable@vger.kernel.org > Addresses-Coverity-ID: 115050 ("Missing break in switch") > Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 62f8c5b..14f1b0c 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -2432,7 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai, snd_soc_component_update_bits(component, WM8994_POWER_MANAGEMENT_2, WM8994_OPCLK_ENA, 0); } - /* fall through */ + break; default: return -EINVAL;
Add missing break statement in order to prevent the code from falling through to the default case. Cc: stable@vger.kernel.org Addresses-Coverity-ID: 115050 ("Missing break in switch") Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- sound/soc/codecs/wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)