Message ID | 20180824152513.8336-2-mdf@kernel.org (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Series | [1/2] fpga: of-fpga-region: Use platform_set_drvdata | expand |
On Fri, Aug 24, 2018 at 08:25:13AM -0700, Moritz Fischer wrote: > Use platform_get_drvdata() in remove() function of > the platform driver rather than dev_get_drvdata() > to match the platform_set_drvdata in the probe(). Hi Moritz, Thanks for this patch, it looks good to me. : ) Hao > > Signed-off-by: Moritz Fischer <mdf@kernel.org> > --- > drivers/fpga/dfl-fme-region.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c > index 0b7e19c27c6d..11d3c23a8936 100644 > --- a/drivers/fpga/dfl-fme-region.c > +++ b/drivers/fpga/dfl-fme-region.c > @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev) > > static int fme_region_remove(struct platform_device *pdev) > { > - struct fpga_region *region = dev_get_drvdata(&pdev->dev); > + struct fpga_region *region = platform_get_drvdata(pdev); > > fpga_region_unregister(region); > fpga_mgr_put(region->mgr); > -- > 2.18.0
On Fri, Aug 24, 2018 at 10:26 AM Moritz Fischer <mdf@kernel.org> wrote: > > Use platform_get_drvdata() in remove() function of > the platform driver rather than dev_get_drvdata() > to match the platform_set_drvdata in the probe(). > > Signed-off-by: Moritz Fischer <mdf@kernel.org> Acked-by: Alan Tull <atull@kernel.org> Thanks, Alan > --- > drivers/fpga/dfl-fme-region.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c > index 0b7e19c27c6d..11d3c23a8936 100644 > --- a/drivers/fpga/dfl-fme-region.c > +++ b/drivers/fpga/dfl-fme-region.c > @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev) > > static int fme_region_remove(struct platform_device *pdev) > { > - struct fpga_region *region = dev_get_drvdata(&pdev->dev); > + struct fpga_region *region = platform_get_drvdata(pdev); > > fpga_region_unregister(region); > fpga_mgr_put(region->mgr); > -- > 2.18.0 >
diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c index 0b7e19c27c6d..11d3c23a8936 100644 --- a/drivers/fpga/dfl-fme-region.c +++ b/drivers/fpga/dfl-fme-region.c @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev) static int fme_region_remove(struct platform_device *pdev) { - struct fpga_region *region = dev_get_drvdata(&pdev->dev); + struct fpga_region *region = platform_get_drvdata(pdev); fpga_region_unregister(region); fpga_mgr_put(region->mgr);
Use platform_get_drvdata() in remove() function of the platform driver rather than dev_get_drvdata() to match the platform_set_drvdata in the probe(). Signed-off-by: Moritz Fischer <mdf@kernel.org> --- drivers/fpga/dfl-fme-region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)