| Message ID | 1535024833-15178-2-git-send-email-merez@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 32dcfe8316cdbd885542967c0c85f5b9de78874b |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wil6210 patches | expand |
Maya Erez <merez@codeaurora.org> wrote: > Reset file is not used and may cause race conditions > with operational driver if used. > > Signed-off-by: Karthick Gopalasubramanian <kargop@codeaurora.org> > Signed-off-by: Maya Erez <merez@codeaurora.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> 9 patches applied to ath-next branch of ath.git, thanks. 32dcfe8316cd wil6210: remove reset file from debugfs 22b9610ec687 wil6210: add support for channel 4 9a65064abdf8 wil6210: drop Rx multicast packets that are looped-back to STA 596bdbcce90f wil6210: set edma variables only for Talyn-MB devices 686ab4f5bd8d wil6210: allocate rx reorder buffer only if rx reorder is enabled df2b53884a5a wil6210: prevent usage of tx ring 0 for eDMA 84f16fbb6238 wil6210: fix RX buffers release and unmap b9010f105f21 wil6210: add FT roam support for AP and station 4405b632e3da wil6210: fix invalid memory access for rx_buff_mgmt debugfs
diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 51c3330..4057f06 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -725,32 +725,6 @@ struct dentry *wil_debugfs_create_ioblob(const char *name, return debugfs_create_file(name, mode, parent, wil_blob, &fops_ioblob); } -/*---reset---*/ -static ssize_t wil_write_file_reset(struct file *file, const char __user *buf, - size_t len, loff_t *ppos) -{ - struct wil6210_priv *wil = file->private_data; - struct net_device *ndev = wil->main_ndev; - - /** - * BUG: - * this code does NOT sync device state with the rest of system - * use with care, debug only!!! - */ - rtnl_lock(); - dev_close(ndev); - ndev->flags &= ~IFF_UP; - rtnl_unlock(); - wil_reset(wil, true); - - return len; -} - -static const struct file_operations fops_reset = { - .write = wil_write_file_reset, - .open = simple_open, -}; - /*---write channel 1..4 to rxon for it, 0 to rxoff---*/ static ssize_t wil_write_file_rxon(struct file *file, const char __user *buf, size_t len, loff_t *ppos) @@ -2451,7 +2425,6 @@ static void wil6210_debugfs_init_blobs(struct wil6210_priv *wil, {"desc", 0444, &fops_txdesc}, {"bf", 0444, &fops_bf}, {"mem_val", 0644, &fops_memread}, - {"reset", 0244, &fops_reset}, {"rxon", 0244, &fops_rxon}, {"tx_mgmt", 0244, &fops_txmgmt}, {"wmi_send", 0244, &fops_wmi},