[kvm-unit-tests,v2,0/5] s390x: simple DXC test

Message

David Hildenbrand Aug. 29, 2018, 3:47 p.m. UTC

The DXC was not handled by TCG correctly (and I have a patch series on
the QEMU list, which fixes that).

Add a simple test case that forces a DATA exception and verifies that
the DXC (0xff) is written to the right locations. One time with and
one time without AFP.

While at it, I found one bug related to storing/saving floating point
registers during interrupts and added one cleanup.

Tested under KVM and under TCG.

v1 -> v2:
- Added "s390x: fix spelling of "initial""
- Minor style + spelling fixes

David Hildenbrand (5):
  s390x: user ctl_set/clear_bit for low address protection
  s390x: fix storing/loading fregs to right address
  s390x: fix spelling of "initial"
  s390x: save/restore cr0 in IRQ handlers
  s390x: test if the DXC is correctly stored

 lib/s390x/asm-offsets.c   |  1 +
 lib/s390x/asm/arch_def.h  |  4 ++-
 lib/s390x/asm/float.h     | 51 +++++++++++++++++++++++++++++++++++++++
 lib/s390x/asm/interrupt.h | 12 ++-------
 s390x/cstart64.S          | 19 ++++++++++-----
 s390x/emulator.c          | 34 ++++++++++++++++++++++++++
 6 files changed, 104 insertions(+), 17 deletions(-)
 create mode 100644 lib/s390x/asm/float.h

Comments

David Hildenbrand Aug. 30, 2018, 4:07 p.m. UTC | #1

On 29.08.2018 17:47, David Hildenbrand wrote:
> The DXC was not handled by TCG correctly (and I have a patch series on
> the QEMU list, which fixes that).
> 
> Add a simple test case that forces a DATA exception and verifies that
> the DXC (0xff) is written to the right locations. One time with and
> one time without AFP.
> 
> While at it, I found one bug related to storing/saving floating point
> registers during interrupts and added one cleanup.
> 
> Tested under KVM and under TCG.
> 
> v1 -> v2:
> - Added "s390x: fix spelling of "initial""
> - Minor style + spelling fixes
> 
> David Hildenbrand (5):
>   s390x: user ctl_set/clear_bit for low address protection
>   s390x: fix storing/loading fregs to right address
>   s390x: fix spelling of "initial"
>   s390x: save/restore cr0 in IRQ handlers
>   s390x: test if the DXC is correctly stored
> 
>  lib/s390x/asm-offsets.c   |  1 +
>  lib/s390x/asm/arch_def.h  |  4 ++-
>  lib/s390x/asm/float.h     | 51 +++++++++++++++++++++++++++++++++++++++
>  lib/s390x/asm/interrupt.h | 12 ++-------
>  s390x/cstart64.S          | 19 ++++++++++-----
>  s390x/emulator.c          | 34 ++++++++++++++++++++++++++
>  6 files changed, 104 insertions(+), 17 deletions(-)
>  create mode 100644 lib/s390x/asm/float.h
> 

I'll queue these and send a pull request.