diff mbox series

[-next] pinctrl: mediatek: make symbol 'mtk_drive' static

Message ID 1537424502-23554-1-git-send-email-weiyongjun1@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] pinctrl: mediatek: make symbol 'mtk_drive' static | expand

Commit Message

Wei Yongjun Sept. 20, 2018, 6:21 a.m. UTC
Fixes the following sparse warning:

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
 symbol 'mtk_drive' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Wang Sept. 21, 2018, 2 a.m. UTC | #1
On Thu, 2018-09-20 at 06:21 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
>  symbol 'mtk_drive' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Acked-by: Sean Wang <sean.wang@mediatek.com>

> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 167ebf4..4a9e0d4 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -34,7 +34,7 @@ struct mtk_drive_desc {
>  };
>  
>  /* The groups of drive strength */
> -const struct mtk_drive_desc mtk_drive[] = {
> +static const struct mtk_drive_desc mtk_drive[] = {
>  	[DRV_GRP0] = { 4, 16, 4, 1 },
>  	[DRV_GRP1] = { 4, 16, 4, 2 },
>  	[DRV_GRP2] = { 2, 8, 2, 1 },
>
Linus Walleij Sept. 21, 2018, 4:03 p.m. UTC | #2
On Wed, Sep 19, 2018 at 11:12 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:

> Fixes the following sparse warning:
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
>  symbol 'mtk_drive' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Patch applied with Sean's ACK.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 167ebf4..4a9e0d4 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -34,7 +34,7 @@  struct mtk_drive_desc {
 };
 
 /* The groups of drive strength */
-const struct mtk_drive_desc mtk_drive[] = {
+static const struct mtk_drive_desc mtk_drive[] = {
 	[DRV_GRP0] = { 4, 16, 4, 1 },
 	[DRV_GRP1] = { 4, 16, 4, 2 },
 	[DRV_GRP2] = { 2, 8, 2, 1 },