| Message ID | 20180920204548.2405-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c15ace868dd16300ec67021903cc354fe0aa0762 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wireless: ipw2x00: Remove unnecessary parentheses | expand |
On 21/09/2018, Nathan Chancellor <natechancellor@gmail.com> wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove > extraneous parentheses around the comparison to silence this warning > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~ ^ ~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to > turn this equality comparison into an assignment > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ^~ > = > 1 warning generated. > > Link: https://github.com/ClangBuiltLinux/linux/issues/134 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Looks fine, thanks! Stanislav.
Nathan Chancellor <natechancellor@gmail.com> wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove > extraneous parentheses around the comparison to silence this warning > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~ ^ ~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to > turn this equality comparison into an assignment > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ^~ > = > 1 warning generated. > > Link: https://github.com/ClangBuiltLinux/linux/issues/134 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Patch applied to wireless-drivers-next.git, thanks. c15ace868dd1 ipw2x00: Remove unnecessary parentheses
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 9644e7b93645..bbdca13c5a9f 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -5652,7 +5652,7 @@ static void ipw_merge_adhoc_network(struct work_struct *work) } mutex_lock(&priv->mutex); - if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { + if (priv->ieee->iw_mode == IW_MODE_ADHOC) { IPW_DEBUG_MERGE("remove network %*pE\n", priv->essid_len, priv->essid); ipw_remove_current_network(priv);
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove extraneous parentheses around the comparison to silence this warning if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ~ ^ ~ drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to turn this equality comparison into an assignment if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { ^~ = 1 warning generated. Link: https://github.com/ClangBuiltLinux/linux/issues/134 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)