| Message ID | 20181129134128.7994-1-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Remove whitelist application from ringbuffer backend | expand |
Quoting Tvrtko Ursulin (2018-11-29 13:41:28) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > There is no white-listing before Gen8 and after the removal ringbuffer > support for these platforms we can remove the call to this no-op. Nope, even my devil's advocate is silent. Though maybe replacing it with a GEM_BUG_ON(!wa.count) would be better. > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On 29/11/2018 14:27, Patchwork wrote: > == Series Details == > > Series: drm/i915: Remove whitelist application from ringbuffer backend > URL : https://patchwork.freedesktop.org/series/53243/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5222 -> Patchwork_10954 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_10954 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_10954, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/53243/revisions/1/mbox/ > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_10954: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@i915_selftest@live_sanitycheck: > - fi-bxt-dsi: PASS -> DMESG-WARN <4> [371.074438] WARNING: CPU: 2 PID: 4072 at sound/hda/hdac_component.c:85 snd_hdac_display_power+0xe6/0x100 [snd_hda_core] <4> [371.074482] Modules linked in: snd_hda_intel i915 amdgpu chash gpu_sched ttm vgem snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel btusb btrtl i2c_i801 lpc_ich btbcm btintel bluetooth snd_hda_codec ecdh_generic snd_hwdep snd_hda_core igb snd_pcm mei_me mei i2c_hid pinctrl_broxton pinctrl_intel prime_numbers [last unloaded: i915] <4> [371.074520] CPU: 2 PID: 4072 Comm: i915_selftest Tainted: G U 4.20.0-rc4-CI-Patchwork_10954+ #1 <4> [371.074523] Hardware name: Intel Corp. Broxton P/Apollolake RVP1A, BIOS APLKRVPA.X64.0150.B11.1608081044 08/08/2016 <4> [371.074532] RIP: 0010:snd_hdac_display_power+0xe6/0x100 [snd_hda_core] <4> [371.074537] Code: 09 49 8b 7d 00 e8 2a 6a b1 e1 be 01 00 00 00 48 89 df e8 ad fe ff ff 31 f6 48 89 df e8 a3 fe ff ff 5b 89 e8 5d 41 5c 41 5d c3 <0f> 0b c7 83 58 05 00 00 ff ff ff ff eb e9 bd ed ff ff ff eb e2 0f <4> [371.074540] RSP: 0018:ffffc9000040bc68 EFLAGS: 00010246 <4> [371.074545] RAX: 00000000ffffffff RBX: ffff88817349b3f8 RCX: 0000000000000000 <4> [371.074548] RDX: 0000000000000006 RSI: 0000000000000000 RDI: ffff88817349b3f8 <4> [371.074552] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 <4> [371.074555] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 <4> [371.074559] R13: ffff88816e800f50 R14: 0000000000000060 R15: ffff88817634a498 <4> [371.074563] FS: 00007f2c2dd09980(0000) GS:ffff88817bb00000(0000) knlGS:0000000000000000 <4> [371.074566] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [371.074570] CR2: 0000557b648f94e8 CR3: 0000000149906000 CR4: 00000000003406e0 <4> [371.074573] Call Trace: <4> [371.074589] snd_hda_codec_dev_free+0x1e/0x30 [snd_hda_codec] <4> [371.074597] __snd_device_free+0x4c/0x80 <4> [371.074602] snd_device_free_all+0x36/0x80 <4> [371.074611] release_card_device+0x14/0x70 <4> [371.074617] device_release+0x2b/0x80 <4> [371.074625] kobject_put+0x85/0x1a0 <4> [371.074632] snd_card_free+0x60/0x90 <4> [371.074647] pci_device_remove+0x36/0xb0 <4> [371.074653] device_release_driver_internal+0x185/0x240 <4> [371.074662] unbind_store+0xaf/0x180 <4> [371.074670] kernfs_fop_write+0x104/0x190 <4> [371.074680] __vfs_write+0x31/0x180 <4> [371.074689] ? rcu_read_lock_sched_held+0x6f/0x80 <4> [371.074693] ? rcu_sync_lockdep_assert+0x29/0x50 <4> [371.074698] ? __sb_start_write+0x152/0x1f0 <4> [371.074703] ? __sb_start_write+0x163/0x1f0 <4> [371.074711] vfs_write+0xbd/0x1b0 <4> [371.074718] ksys_write+0x50/0xc0 <4> [371.074727] do_syscall_64+0x55/0x190 <4> [371.074735] entry_SYSCALL_64_after_hwframe+0x49/0xbe A-R-G-H... Regards, Tvrtko > > * {igt@runner@aborted}: > - fi-bxt-dsi: NOTRUN -> FAIL > > > Known issues > ------------ > > Here are the changes found in Patchwork_10954 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_frontbuffer_tracking@basic: > - {fi-icl-u3}: PASS -> FAIL [fdo#103167] > > * {igt@runner@aborted}: > - {fi-icl-y}: NOTRUN -> FAIL [fdo#108070] > > > #### Possible fixes #### > > * igt@gem_mmap_gtt@basic: > - fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 > [fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070 > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 > > > Participating hosts (49 -> 44) > ------------------------------ > > Additional (1): fi-icl-y > Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 > > > Build changes > ------------- > > * Linux: CI_DRM_5222 -> Patchwork_10954 > > CI_DRM_5222: a6f85043a0ca86eb0072e69bf92b77f7d9d6d5d5 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_10954: 39a3d63b054d5073c2cecb6d27757ae3d7095ddc @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 39a3d63b054d drm/i915: Remove whitelist application from ringbuffer backend > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10954/ >
On 29/11/2018 17:48, Patchwork wrote: > == Series Details == > > Series: drm/i915: Remove whitelist application from ringbuffer backend (rev3) > URL : https://patchwork.freedesktop.org/series/53243/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_5224 -> Patchwork_10960 > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/53243/revisions/3/mbox/ > > Known issues > ------------ > > Here are the changes found in Patchwork_10960 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: > - fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] > > * igt@kms_pipe_crc_basic@read-crc-pipe-a: > - fi-byt-clapper: PASS -> FAIL [fdo#107362] +1 > > > #### Possible fixes #### > > * igt@kms_frontbuffer_tracking@basic: > - fi-byt-clapper: FAIL [fdo#103167] -> PASS > > * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: > - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS > > > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 > > > Participating hosts (50 -> 42) > ------------------------------ > > Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y > > > Build changes > ------------- > > * Linux: CI_DRM_5224 -> Patchwork_10960 > > CI_DRM_5224: 67ee0d0da79f5b32636d496fd2127da1eecf6262 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_10960: 2c213561982b431d679d5839a1c3f345fe275381 @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 2c213561982b drm/i915: Remove whitelist application from ringbuffer backend Pushed, thanks for the review! Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index e18a64d41843..28ae1e436ea6 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -667,8 +667,6 @@ static int init_render_ring(struct intel_engine_cs *engine) if (ret) return ret; - intel_whitelist_workarounds_apply(engine); - /* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */ if (IS_GEN(dev_priv, 4, 6)) I915_WRITE(MI_MODE, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH));