mbox series

[rds,linux-next,v3,0/2] WARNING in rds_message_alloc_sgs

Message ID 20181213083814.2340-1-shamir.rabinovitch@oracle.com (mailing list archive)
Headers show
Series WARNING in rds_message_alloc_sgs | expand

Message

Shamir Rabinovitch Dec. 13, 2018, 8:38 a.m. UTC
From: shamir rabinovitch <shamir.rabinovitch@oracle.com>

This patch set fix google syzbot rds bug found in linux-next.
The first patch solve the syzbot issue.
The second patch fix issue mentioned by Leon Romanovsky that
drivers should not call WARN_ON as result from user input.

syzbot bug report can be foud here: https://lkml.org/lkml/2018/10/31/28

v1->v2:
- patch 1: make rds_iov_vector fields name more descriptive (Hakon)
- patch 1: fix potential mem leak in rds_rm_size if krealloc fail
  (Hakon)
v2->v3:
- patch 2: harden rds_sendmsg for invalid number of sgs (Gerd)

Santosh - we need your ack on both patches now

shamir rabinovitch (2):
  net/rds: fix warn in rds_message_alloc_sgs
  net/rds: remove user triggered WARN_ON in rds_sendmsg

 net/rds/message.c | 24 +++++++++++----
 net/rds/rdma.c    | 75 +++++++++++++++++++++++------------------------
 net/rds/rds.h     | 23 +++++++++++----
 net/rds/send.c    | 59 ++++++++++++++++++++++++++++++-------
 4 files changed, 120 insertions(+), 61 deletions(-)

Comments

Santosh Shilimkar Dec. 13, 2018, 5:08 p.m. UTC | #1
On 12/13/18 12:38 AM, Shamir Rabinovitch wrote:
> From: shamir rabinovitch <shamir.rabinovitch@oracle.com>
> 
> This patch set fix google syzbot rds bug found in linux-next.
> The first patch solve the syzbot issue.
> The second patch fix issue mentioned by Leon Romanovsky that
> drivers should not call WARN_ON as result from user input.
> 
> syzbot bug report can be foud here: https://lkml.org/lkml/2018/10/31/28
> 
> v1->v2:
> - patch 1: make rds_iov_vector fields name more descriptive (Hakon)
> - patch 1: fix potential mem leak in rds_rm_size if krealloc fail
>    (Hakon)
> v2->v3:
> - patch 2: harden rds_sendmsg for invalid number of sgs (Gerd)
> 
> Santosh - we need your ack on both patches now
> 
Done. BTW, you need to post patches to net-dev.

Regards,
Santosh