| Message ID | 154510700291.1941238.817190985966612531.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mm: Randomize free memory | expand |
On Mon 17-12-18 20:23:23, Dan Williams wrote: > Andrew, this needs at least an ack from Michal, or Mel before it moves > forward. It would be a nice surprise / present to see it move forward > before the holidays, but I suspect it may need to simmer until the new > year. This series is against v4.20-rc6. I am sorry but I am unlikely to look into this before the end of the year and I do not want to promise early days in new year either because who knows how much stuff piles up by then. But this is definitely on my radar.
On Wed, Dec 19, 2018 at 12:32 PM Michal Hocko <mhocko@kernel.org> wrote: > > On Mon 17-12-18 20:23:23, Dan Williams wrote: > > Andrew, this needs at least an ack from Michal, or Mel before it moves > > forward. It would be a nice surprise / present to see it move forward > > before the holidays, but I suspect it may need to simmer until the new > > year. This series is against v4.20-rc6. > > I am sorry but I am unlikely to look into this before the end of the > year and I do not want to promise early days in new year either because > who knows how much stuff piles up by then. But this is definitely on my > radar. Ok, I'll hold off on posting v7 until the 4.21/5.0 -rc2 timeframe.
Changes since v5 [1]: * Add missing kernel-doc for new functionality, and fold some changes from patch 4 to patch 3. (Mike) * Actually include the HMAT parsing, and test the autodetect in QEMU. (Keith) * Test against hibernation. Note, only a basic checkout with pm_test in QEMU was performed. (Rafael) * Fix up interaction between auto-detect, override, and the status value exported to /sys/module/page_alloc/parameters/shuffle * Don't pollute mm.h, move the new functionality to its own header. [1]: https://lkml.kernel.org/r/154483851047.1672629.15001135860756738866.stgit@dwillia2-desk3.amr.corp.intel.com/ --- Andrew, this needs at least an ack from Michal, or Mel before it moves forward. It would be a nice surprise / present to see it move forward before the holidays, but I suspect it may need to simmer until the new year. This series is against v4.20-rc6. Summary, quote patch 4: Randomization of the page allocator improves the average utilization of a direct-mapped memory-side-cache. Memory side caching is a platform capability that Linux has been previously exposed to in HPC (high-performance computing) environments on specialty platforms. In that instance it was a smaller pool of high-bandwidth-memory relative to higher-capacity / lower-bandwidth DRAM. Now, this capability is going to be found on general purpose server platforms where DRAM is a cache in front of higher latency persistent memory [2]. Robert offered an explanation of the state of the art of Linux interactions with memory-side-caches [3], and I copy it here: It's been a problem in the HPC space: http://www.nersc.gov/research-and-development/knl-cache-mode-performance-coe/ A kernel module called zonesort is available to try to help: https://software.intel.com/en-us/articles/xeon-phi-software and this abandoned patch series proposed that for the kernel: https://lkml.org/lkml/2017/8/23/195 Dan's patch series doesn't attempt to ensure buffers won't conflict, but also reduces the chance that the buffers will. This will make performance more consistent, albeit slower than "optimal" (which is near impossible to attain in a general-purpose kernel). That's better than forcing users to deploy remedies like: "To eliminate this gradual degradation, we have added a Stream measurement to the Node Health Check that follows each job; nodes are rebooted whenever their measured memory bandwidth falls below 300 GB/s." A replacement for zonesort was merged upstream in commit cc9aec03e58f "x86/numa_emulation: Introduce uniform split capability". With this numa_emulation capability, memory can be split into cache sized ("near-memory" sized) numa nodes. A bind operation to such a node, and disabling workloads on other nodes, enables full cache performance. However, once the workload exceeds the cache size then cache conflicts are unavoidable. While HPC environments might be able to tolerate time-scheduling of cache sized workloads, for general purpose server platforms, the oversubscribed cache case will be the common case. The worst case scenario is that a server system owner benchmarks a workload at boot with an un-contended cache only to see that performance degrade over time, even below the average cache performance due to excessive conflicts. Randomization clips the peaks and fills in the valleys of cache utilization to yield steady average performance. See patch 3 for more details. [2]: https://itpeernetwork.intel.com/intel-optane-dc-persistent-memory-operating-modes/ [3]: https://lkml.org/lkml/2018/9/22/54 --- Dan Williams (3): mm: Shuffle initial free memory to improve memory-side-cache utilization mm: Move buddy list manipulations into helpers mm: Maintain randomization of page free lists Keith Busch (3): acpi: Create subtable parsing infrastructure acpi: Add HMAT to generic parsing tables acpi/numa: Set the memory-side-cache size in memblocks arch/ia64/kernel/acpi.c | 12 + arch/x86/Kconfig | 1 arch/x86/kernel/acpi/boot.c | 36 ++-- drivers/acpi/numa.c | 48 ++++- drivers/acpi/scan.c | 4 drivers/acpi/tables.c | 76 +++++++- drivers/irqchip/irq-gic-v2m.c | 2 drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 drivers/irqchip/irq-gic-v3-its-platform-msi.c | 2 drivers/irqchip/irq-gic-v3-its.c | 6 - drivers/irqchip/irq-gic-v3.c | 8 - drivers/irqchip/irq-gic.c | 4 drivers/mailbox/pcc.c | 2 include/linux/acpi.h | 6 + include/linux/list.h | 17 ++ include/linux/memblock.h | 38 ++++ include/linux/mm.h | 3 include/linux/mm_types.h | 3 include/linux/mmzone.h | 65 +++++++ include/linux/shuffle.h | 59 ++++++ init/Kconfig | 36 ++++ mm/Kconfig | 3 mm/Makefile | 7 + mm/compaction.c | 4 mm/memblock.c | 50 +++++ mm/memory_hotplug.c | 3 mm/page_alloc.c | 82 ++++----- mm/shuffle.c | 231 +++++++++++++++++++++++++ 28 files changed, 702 insertions(+), 108 deletions(-) create mode 100644 include/linux/shuffle.h create mode 100644 mm/shuffle.c