| Message ID | 1544642406-24272-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 861cb5eb467f5e38dce1aabe4e8db379255bd89b |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: Fix access point mode | expand |
On 12/12/2018 8:20 PM, Stefan Wahren wrote: > Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") > the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with > hostapd (device_ap_sme=1 use_monitor=0): > > brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52 > > So add the missing mgmt_stypes for AP mode to fix this. > > Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") > Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com> Thanks for submitting this patch. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > index 7f0a5ba..05bd818 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = { > .tx = 0xffff, > .rx = BIT(IEEE80211_STYPE_ACTION >> 4) | > BIT(IEEE80211_STYPE_PROBE_REQ >> 4) > + }, > + [NL80211_IFTYPE_AP] = { > + .tx = 0xffff, > + .rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) | > + BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) | > + BIT(IEEE80211_STYPE_PROBE_REQ >> 4) | > + BIT(IEEE80211_STYPE_DISASSOC >> 4) | > + BIT(IEEE80211_STYPE_AUTH >> 4) | > + BIT(IEEE80211_STYPE_DEAUTH >> 4) | > + BIT(IEEE80211_STYPE_ACTION >> 4) > } > }; > >
Stefan Wahren <stefan.wahren@i2se.com> wrote: > Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") > the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with > hostapd (device_ap_sme=1 use_monitor=0): > > brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52 > > So add the missing mgmt_stypes for AP mode to fix this. > > Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") > Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-drivers-next.git, thanks. 861cb5eb467f brcmfmac: Fix access point mode
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 7f0a5ba..05bd818 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = { .tx = 0xffff, .rx = BIT(IEEE80211_STYPE_ACTION >> 4) | BIT(IEEE80211_STYPE_PROBE_REQ >> 4) + }, + [NL80211_IFTYPE_AP] = { + .tx = 0xffff, + .rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) | + BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) | + BIT(IEEE80211_STYPE_PROBE_REQ >> 4) | + BIT(IEEE80211_STYPE_DISASSOC >> 4) | + BIT(IEEE80211_STYPE_AUTH >> 4) | + BIT(IEEE80211_STYPE_DEAUTH >> 4) | + BIT(IEEE80211_STYPE_ACTION >> 4) } };
Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with hostapd (device_ap_sme=1 use_monitor=0): brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52 So add the missing mgmt_stypes for AP mode to fix this. Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++ 1 file changed, 10 insertions(+)