| Message ID | 20190124144738.7961-3-haakon.bugge@oracle.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | ibacm: Replace ioctl with netlink and fix inablity to resurrect an interface | expand |
On Thu, Jan 24, 2019 at 03:47:36PM +0100, Håkon Bugge wrote: > In commit 0161b49e3e1e ("ibacm: Unable to assign EP name for limited > pkey"), a fix was introduced enabling an ipoib interface to be > associated with its corresponding IB port, when a limited pkey was > used. > > Said commit missed to change the debug print, such that the real pkey > was printed. > > Fixes: 0161b49e3e1e ("ibacm: Unable to assign EP name for limited pkey") > Change-Id: I5ec20a4a36d4e822cae0b906dd480dcf681ea0b5 > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > ibacm/src/acm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c > index e8d50a4a..a05a3cc0 100644 > --- a/ibacm/src/acm.c > +++ b/ibacm/src/acm.c > @@ -2090,7 +2090,7 @@ static void acm_ep_ip_iter_cb(char *ifname, union ibv_gid *gid, uint16_t pkey, > (ep->endpoint.pkey | IB_PKEY_FULL_MEMBER) == pkey) { > if (!acm_ep_insert_addr(ep, ip_str, addr, addr_type)) { > acm_log(0, "Added %s %s %d 0x%x from %s\n", ip_str, > - dev->device.verbs->device->name, port_num, pkey, > + dev->device.verbs->device->name, port_num, ep->endpoint.pkey, > ifname); > } > } > -- > 2.20.1 >
> On 25 Jan 2019, at 19:03, Ira Weiny <ira.weiny@intel.com> wrote: > > On Thu, Jan 24, 2019 at 03:47:36PM +0100, Håkon Bugge wrote: >> In commit 0161b49e3e1e ("ibacm: Unable to assign EP name for limited >> pkey"), a fix was introduced enabling an ipoib interface to be >> associated with its corresponding IB port, when a limited pkey was >> used. >> >> Said commit missed to change the debug print, such that the real pkey >> was printed. >> >> Fixes: 0161b49e3e1e ("ibacm: Unable to assign EP name for limited pkey") >> Change-Id: I5ec20a4a36d4e822cae0b906dd480dcf681ea0b5 >> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> Thank you! Håkon
diff --git a/ibacm/src/acm.c b/ibacm/src/acm.c index e8d50a4a..a05a3cc0 100644 --- a/ibacm/src/acm.c +++ b/ibacm/src/acm.c @@ -2090,7 +2090,7 @@ static void acm_ep_ip_iter_cb(char *ifname, union ibv_gid *gid, uint16_t pkey, (ep->endpoint.pkey | IB_PKEY_FULL_MEMBER) == pkey) { if (!acm_ep_insert_addr(ep, ip_str, addr, addr_type)) { acm_log(0, "Added %s %s %d 0x%x from %s\n", ip_str, - dev->device.verbs->device->name, port_num, pkey, + dev->device.verbs->device->name, port_num, ep->endpoint.pkey, ifname); } }
In commit 0161b49e3e1e ("ibacm: Unable to assign EP name for limited pkey"), a fix was introduced enabling an ipoib interface to be associated with its corresponding IB port, when a limited pkey was used. Said commit missed to change the debug print, such that the real pkey was printed. Fixes: 0161b49e3e1e ("ibacm: Unable to assign EP name for limited pkey") Change-Id: I5ec20a4a36d4e822cae0b906dd480dcf681ea0b5 Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> --- ibacm/src/acm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)