| Message ID | 228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | mt76: change the retun type of mt76_dma_attach() | expand |
Hello! On 11.02.2019 5:13, Ryder Lee wrote: > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. ^ r missing :-) > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> [...] MBR, Sergei
On Mon, 2019-02-11 at 11:38 +0300, Sergei Shtylyov wrote: > Hello! > > On 11.02.2019 5:13, Ryder Lee wrote: > > > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. > ^ r missing :-) > > > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > [...] > > MBR, Sergei > I will resend a new one. Thanks Ryder
Ryder Lee <ryder.lee@mediatek.com> writes: > There is no need to return 0 in mt76_dma_attach(), so switch it to void. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> When you send a new version mark it as v2: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing And add a changelog: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing No need to resend because of this, but please do remember this in the future.
On 2019-02-11 03:13, Ryder Lee wrote: > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> Applied, thanks. - Felix
diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c index e2ba263..d934d72 100644 --- a/drivers/net/wireless/mediatek/mt76/dma.c +++ b/drivers/net/wireless/mediatek/mt76/dma.c @@ -522,10 +522,9 @@ int mt76_dma_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q, .kick = mt76_dma_kick_queue, }; -int mt76_dma_attach(struct mt76_dev *dev) +void mt76_dma_attach(struct mt76_dev *dev) { dev->queue_ops = &mt76_dma_ops; - return 0; } EXPORT_SYMBOL_GPL(mt76_dma_attach); diff --git a/drivers/net/wireless/mediatek/mt76/dma.h b/drivers/net/wireless/mediatek/mt76/dma.h index 357cc35..e3292df 100644 --- a/drivers/net/wireless/mediatek/mt76/dma.h +++ b/drivers/net/wireless/mediatek/mt76/dma.h @@ -54,7 +54,7 @@ enum mt76_mcu_evt_type { EVT_EVENT_DFS_DETECT_RSP, }; -int mt76_dma_attach(struct mt76_dev *dev); +void mt76_dma_attach(struct mt76_dev *dev); void mt76_dma_cleanup(struct mt76_dev *dev); #endif
There is no need to retun 0 in mt76_dma_attach(), so switch it to void. Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> --- drivers/net/wireless/mediatek/mt76/dma.c | 3 +-- drivers/net/wireless/mediatek/mt76/dma.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)