| Message ID | 20180705203807.GA10327@embeddedor.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Thu, Jul 05, 2018 at 03:38:07PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> I've applied this patch, but not the acer or sony fall through patches due to the pending questions there. Happy to revisit those as needed, but closing these out of the patch queue. > --- > drivers/platform/x86/dell-laptop.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index f1fa861..1938f11 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev, > switch (unit) { > case KBD_TIMEOUT_DAYS: > value *= 24; > + /* fall through */ > case KBD_TIMEOUT_HOURS: > value *= 60; > + /* fall through */ > case KBD_TIMEOUT_MINUTES: > value *= 60; > unit = KBD_TIMEOUT_SECONDS; > -- > 2.7.4 > >
On 11/28/18 6:15 PM, Darren Hart wrote: > On Thu, Jul 05, 2018 at 03:38:07PM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > I've applied this patch, but not the acer or sony fall through patches > due to the pending questions there. Happy to revisit those as needed, > but closing these out of the patch queue. > Thanks, Darren. I'll send separate patches for those that are still pending. Hopefully, I'll get some feedback this time. -- Gustavo >> --- >> drivers/platform/x86/dell-laptop.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c >> index f1fa861..1938f11 100644 >> --- a/drivers/platform/x86/dell-laptop.c >> +++ b/drivers/platform/x86/dell-laptop.c >> @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev, >> switch (unit) { >> case KBD_TIMEOUT_DAYS: >> value *= 24; >> + /* fall through */ >> case KBD_TIMEOUT_HOURS: >> value *= 60; >> + /* fall through */ >> case KBD_TIMEOUT_MINUTES: >> value *= 60; >> unit = KBD_TIMEOUT_SECONDS; >> -- >> 2.7.4 >> >> >
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index f1fa861..1938f11 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev, switch (unit) { case KBD_TIMEOUT_DAYS: value *= 24; + /* fall through */ case KBD_TIMEOUT_HOURS: value *= 60; + /* fall through */ case KBD_TIMEOUT_MINUTES: value *= 60; unit = KBD_TIMEOUT_SECONDS;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/platform/x86/dell-laptop.c | 2 ++ 1 file changed, 2 insertions(+)