| Message ID | 20190221080009.22926-1-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | writeback.h: Removed duplicated declaration of tag_pages_for_writeback() | expand |
On 21.02.19 г. 10:00 ч., Qu Wenruo wrote: > There are two commits introducing the same declaration, 92c09c041f15 > ("mm: declare some external symbols") and 5b41d92437f1 > ("ext4: implement writeback livelock avoidance using page tagging"), > they are all introducing declaration for tag_pages_for_writeback(), just > lines apart. > > One declaration is enough. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > include/linux/writeback.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 738a0c24874f..e926fa256c43 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -371,8 +371,6 @@ int write_cache_pages(struct address_space *mapping, > void *data); > int do_writepages(struct address_space *mapping, struct writeback_control *wbc); > void writeback_set_ratelimit(void); > -void tag_pages_for_writeback(struct address_space *mapping, > - pgoff_t start, pgoff_t end); > > void account_page_redirty(struct page *page); > >
diff --git a/include/linux/writeback.h b/include/linux/writeback.h index 738a0c24874f..e926fa256c43 100644 --- a/include/linux/writeback.h +++ b/include/linux/writeback.h @@ -371,8 +371,6 @@ int write_cache_pages(struct address_space *mapping, void *data); int do_writepages(struct address_space *mapping, struct writeback_control *wbc); void writeback_set_ratelimit(void); -void tag_pages_for_writeback(struct address_space *mapping, - pgoff_t start, pgoff_t end); void account_page_redirty(struct page *page);
There are two commits introducing the same declaration, 92c09c041f15 ("mm: declare some external symbols") and 5b41d92437f1 ("ext4: implement writeback livelock avoidance using page tagging"), they are all introducing declaration for tag_pages_for_writeback(), just lines apart. One declaration is enough. Signed-off-by: Qu Wenruo <wqu@suse.com> --- include/linux/writeback.h | 2 -- 1 file changed, 2 deletions(-)