| Message ID | 20190221010233.GA29228@embeddedor (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7264235ee74f51d26fbdf97bf98c6102a460484f |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | IB/hfi1: Add missing break in switch statement | expand |
> -----Original Message----- > From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com] > Sent: Wednesday, February 20, 2019 8:03 PM > To: Wan, Kaike <kaike.wan@intel.com>; Marciniszyn, Mike > <mike.marciniszyn@intel.com>; Dalessandro, Dennis > <dennis.dalessandro@intel.com>; Doug Ledford <dledford@redhat.com>; > Jason Gunthorpe <jgg@ziepe.ca> > Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. > Silva <gustavo@embeddedor.com>; Kees Cook <keescook@chromium.org> > Subject: [PATCH] IB/hfi1: Add missing break in switch statement > > Fix the following warning by adding a missing break: > > drivers/infiniband/hw/hfi1/tid_rdma.c: In function > ‘hfi1_tid_rdma_wqe_interlock’: > drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may > fall through [-Wimplicit-fallthrough=] > switch (prev->wr.opcode) { > ^~~~~~ > drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here > case IB_WR_RDMA_READ: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. > > Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and > other requests") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c > b/drivers/infiniband/hw/hfi1/tid_rdma.c > index bc2ff83026f7..fdda33aca77f 100644 > --- a/drivers/infiniband/hw/hfi1/tid_rdma.c > +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c > @@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp > *qp, struct rvt_swqe *wqe) > default: > break; > } > + break; > case IB_WR_RDMA_READ: > if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE) > break; > -- Reviewed-by: Kaike Wan <Kaike.wan@intel.com> > 2.20.1
On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote: > Fix the following warning by adding a missing break: > > drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’: > drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > switch (prev->wr.opcode) { > ^~~~~~ > drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here > case IB_WR_RDMA_READ: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Reviewed-by: Kaike Wan <Kaike.wan@intel.com> > -- > drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + > 1 file changed, 1 insertion(+) Applied to for-next, thanks Jason
On 2/21/19 3:09 PM, Jason Gunthorpe wrote: > On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote: >> Fix the following warning by adding a missing break: >> >> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’: >> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=] >> switch (prev->wr.opcode) { >> ^~~~~~ >> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here >> case IB_WR_RDMA_READ: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> Reviewed-by: Kaike Wan <Kaike.wan@intel.com> >> -- >> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + >> 1 file changed, 1 insertion(+) > > Applied to for-next, thanks > Great. :) Thank you both, Kaike and Jason. -- Gustavo
diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c index bc2ff83026f7..fdda33aca77f 100644 --- a/drivers/infiniband/hw/hfi1/tid_rdma.c +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c @@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe) default: break; } + break; case IB_WR_RDMA_READ: if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE) break;
Fix the following warning by adding a missing break: drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’: drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (prev->wr.opcode) { ^~~~~~ drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here case IB_WR_RDMA_READ: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/infiniband/hw/hfi1/tid_rdma.c | 1 + 1 file changed, 1 insertion(+)