[v2,0/5] drm/i915/icl: split pll functions

Message

Lucas De Marchi March 9, 2019, 3:57 a.m. UTC

v2 of https://patchwork.freedesktop.org/series/57618/

Only difference is that patch 2 got replaced with a different one.
Instead of passing a function pointer to write the pll, split the
function in three and pass the different arguments for each type of
plls as suggested by Ville. I think this is neater and cleaner as
well.

Lucas De Marchi (5):
  drm/i915/icl: split combo and mg pll enable
  drm/i915/icl: split pll enable in three steps
  drm/i915/icl: split combo and mg pll disable
  drm/i915/icl: split combo and tbt pll funcs
  drm/i915/icl: remove intel_dpll_is_combophy()

 drivers/gpu/drm/i915/intel_display.c  |   3 -
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 174 +++++++++++++++++++-------
 2 files changed, 127 insertions(+), 50 deletions(-)

Comments

Ville Syrjälä March 11, 2019, 4:28 p.m. UTC | #1

On Fri, Mar 08, 2019 at 07:57:22PM -0800, Lucas De Marchi wrote:
> v2 of https://patchwork.freedesktop.org/series/57618/
> 
> Only difference is that patch 2 got replaced with a different one.
> Instead of passing a function pointer to write the pll, split the
> function in three and pass the different arguments for each type of
> plls as suggested by Ville. I think this is neater and cleaner as
> well.
> 
> Lucas De Marchi (5):
>   drm/i915/icl: split combo and mg pll enable
>   drm/i915/icl: split pll enable in three steps
>   drm/i915/icl: split combo and mg pll disable
>   drm/i915/icl: split combo and tbt pll funcs
>   drm/i915/icl: remove intel_dpll_is_combophy()

Series is
Reviewed-by: Ville Syrjälä <[e-mail]>

> 
>  drivers/gpu/drm/i915/intel_display.c  |   3 -
>  drivers/gpu/drm/i915/intel_dpll_mgr.c | 174 +++++++++++++++++++-------
>  2 files changed, 127 insertions(+), 50 deletions(-)
> 
> -- 
> 2.20.1