| Message ID | 20190313104249.5483-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Format-declare struct drm_format_info in drm_framebuffer.h | expand |
On Wed, 13 Mar 2019, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > drm_framebuffer.h makes use of a pointer to struct drm_format_info but > doesn't include drm_fourcc.h (neither directly nor indirectly). > Forward-declare the structure. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> With the subject typo fixed, Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_framebuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h > index f0b34c977ec5..c23016748e3f 100644 > --- a/include/drm/drm_framebuffer.h > +++ b/include/drm/drm_framebuffer.h > @@ -32,6 +32,7 @@ > struct drm_clip_rect; > struct drm_device; > struct drm_file; > +struct drm_format_info; > struct drm_framebuffer; > struct drm_gem_object;
Hi Laurent. On Wed, Mar 13, 2019 at 12:42:49PM +0200, Laurent Pinchart wrote: > drm_framebuffer.h makes use of a pointer to struct drm_format_info but > doesn't include drm_fourcc.h (neither directly nor indirectly). > Forward-declare the structure. Yep, this is the way to fix this. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index f0b34c977ec5..c23016748e3f 100644 --- a/include/drm/drm_framebuffer.h +++ b/include/drm/drm_framebuffer.h @@ -32,6 +32,7 @@ struct drm_clip_rect; struct drm_device; struct drm_file; +struct drm_format_info; struct drm_framebuffer; struct drm_gem_object;
drm_framebuffer.h makes use of a pointer to struct drm_format_info but doesn't include drm_fourcc.h (neither directly nor indirectly). Forward-declare the structure. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- include/drm/drm_framebuffer.h | 1 + 1 file changed, 1 insertion(+)