| Message ID | 20190304222841.13899-7-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce the generic ECC engine abstraction | expand |
On Mon, 4 Mar 2019 23:28:11 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Prepare the migration to a generic ECC engine by renaming the > nand_ecc_req structure into nand_ecc_conf. This structure will be the > base of a wider 'nand_ecc' structure. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > include/linux/mtd/nand.h | 8 ++++---- > include/linux/mtd/spinand.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index 84ab76f34c74..78cf905083c9 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -123,11 +123,11 @@ struct nand_page_io_req { > }; > > /** > - * struct nand_ecc_req - NAND ECC requirements > + * struct nand_ecc_conf - NAND ECC configuration Maybe nand_ecc_info, nand_ecc_caps or nand_ecc_props would be more appropriate as _conf seems to imply you can change it, which is not the case when you use this struct to express chip requirements or when you use an on-die ECC which is not configurable. > * @strength: ECC strength > - * @step_size: ECC step/block size > + * @step_size: Number of bytes per step > */ > -struct nand_ecc_req { > +struct nand_ecc_conf { > unsigned int strength; > unsigned int step_size; > }; > @@ -186,7 +186,7 @@ struct nand_ops { > struct nand_device { > struct mtd_info mtd; > struct nand_memory_organization memorg; > - struct nand_ecc_req eccreq; > + struct nand_ecc_conf eccreq; > struct nand_row_converter rowconv; > struct nand_bbt bbt; > const struct nand_ops *ops; > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..3008de54f958 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -263,7 +263,7 @@ struct spinand_info { > u8 devid; > u32 flags; > struct nand_memory_organization memorg; > - struct nand_ecc_req eccreq; > + struct nand_ecc_conf eccreq; > struct spinand_ecc_info eccinfo; > struct { > const struct spinand_op_variants *read_cache;
Hi Boris, Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 31 Mar 2019 13:30:01 +0200: > On Mon, 4 Mar 2019 23:28:11 +0100 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > Prepare the migration to a generic ECC engine by renaming the > > nand_ecc_req structure into nand_ecc_conf. This structure will be the > > base of a wider 'nand_ecc' structure. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > include/linux/mtd/nand.h | 8 ++++---- > > include/linux/mtd/spinand.h | 2 +- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > > index 84ab76f34c74..78cf905083c9 100644 > > --- a/include/linux/mtd/nand.h > > +++ b/include/linux/mtd/nand.h > > @@ -123,11 +123,11 @@ struct nand_page_io_req { > > }; > > > > /** > > - * struct nand_ecc_req - NAND ECC requirements > > + * struct nand_ecc_conf - NAND ECC configuration > > Maybe nand_ecc_info, nand_ecc_caps or nand_ecc_props would be more > appropriate as _conf seems to imply you can change it, which is not > the case when you use this struct to express chip requirements or when > you use an on-die ECC which is not configurable. nand_ecc_props sounds good to me! Thanks, Miquèl
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 84ab76f34c74..78cf905083c9 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -123,11 +123,11 @@ struct nand_page_io_req { }; /** - * struct nand_ecc_req - NAND ECC requirements + * struct nand_ecc_conf - NAND ECC configuration * @strength: ECC strength - * @step_size: ECC step/block size + * @step_size: Number of bytes per step */ -struct nand_ecc_req { +struct nand_ecc_conf { unsigned int strength; unsigned int step_size; }; @@ -186,7 +186,7 @@ struct nand_ops { struct nand_device { struct mtd_info mtd; struct nand_memory_organization memorg; - struct nand_ecc_req eccreq; + struct nand_ecc_conf eccreq; struct nand_row_converter rowconv; struct nand_bbt bbt; const struct nand_ops *ops; diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..3008de54f958 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -263,7 +263,7 @@ struct spinand_info { u8 devid; u32 flags; struct nand_memory_organization memorg; - struct nand_ecc_req eccreq; + struct nand_ecc_conf eccreq; struct spinand_ecc_info eccinfo; struct { const struct spinand_op_variants *read_cache;
Prepare the migration to a generic ECC engine by renaming the nand_ecc_req structure into nand_ecc_conf. This structure will be the base of a wider 'nand_ecc' structure. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- include/linux/mtd/nand.h | 8 ++++---- include/linux/mtd/spinand.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)