diff mbox series

[1/2] ftpm: dt-binding: add dts documentation for fTPM driver

Message ID 20190402193316.15144-1-sashal@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] ftpm: dt-binding: add dts documentation for fTPM driver | expand

Commit Message

Sasha Levin April 2, 2019, 7:33 p.m. UTC
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 .../bindings/security/tpm/tpm_ftpm_tee.txt          | 13 +++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt         |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt

Comments

Greg Kroah-Hartman April 2, 2019, 7:37 p.m. UTC | #1
On Tue, Apr 02, 2019 at 03:33:15PM -0400, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

I know I don't take patches without any changelog text :)
Sasha Levin April 2, 2019, 8:03 p.m. UTC | #2
On Tue, Apr 02, 2019 at 09:37:32PM +0200, Greg KH wrote:
>On Tue, Apr 02, 2019 at 03:33:15PM -0400, Sasha Levin wrote:
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>
>I know I don't take patches without any changelog text :)

I honestly don't have anything meaningful to add in the changelog, and
looking at similar commits under Documentation/devicetree/bindings/ that
just add a new binding, they have a very similar changelog as well (see
204d94e63e22, 772bf73ed4dc, and b805c403c859 for example).

While I could add meaningless text which basically copies the subject
line, I don't think it will solve the concern you're pointing out here.

There is a lot of documentation for the fTPM driver which is listed in
the following patch, but it's not relevant to this patch at all.

--
Thanks,
Sasha
Jarkko Sakkinen April 3, 2019, 6:15 p.m. UTC | #3
On Tue, Apr 02, 2019 at 03:33:15PM -0400, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt b/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt
new file mode 100644
index 000000000000..20fca67a56c4
--- /dev/null
+++ b/Documentation/devicetree/bindings/security/tpm/tpm_ftpm_tee.txt
@@ -0,0 +1,13 @@ 
+Required properties:
+- compatible: should be "microsoft,ftpm"
+- linux,sml-base: 64-bit base address of the reserved memory allocated
+		  for the firmware event log
+- linux,sml-size: size of the memory allocated for the firmware event log
+
+Example:
+
+tpm@0 {
+	compatible = "microsoft,ftpm";
+	linux,sml-base = <0x0 0xC0000000>;
+	linux,sml-size = <0x10000>;
+};
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 8162b0eb4b50..902798bcb9a5 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -249,6 +249,7 @@  micrel	Micrel Inc.
 microchip	Microchip Technology Inc.
 microcrystal	Micro Crystal AG
 micron	Micron Technology Inc.
+microsoft	Microsoft Corporation
 mikroe		MikroElektronika d.o.o.
 minix	MINIX Technology Ltd.
 miramems	MiraMEMS Sensing Technology Co., Ltd.