| Message ID | 1553005870-28018-1-git-send-email-chongguiguzi@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 38bb0baea310fc4b5897ec47b1546bc989b33663 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | net:rtlwifi:move spin_lock_bh to spin_lock in tasklet | expand |
On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> > > --- > drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c > b/drivers/net/wireless/realtek/rtlwifi/pci.c > index 48ca521..4055e0a 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw > *hw) > > memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc)); > > - spin_lock_bh(&rtlpriv->locks.waitq_lock); > + spin_lock(&rtlpriv->locks.waitq_lock); > if (!skb_queue_empty(&mac->skb_waitq[tid]) && > (ring->entries - skb_queue_len(&ring->queue) > > rtlhal->max_earlymode_num)) { > skb = skb_dequeue(&mac->skb_waitq[tid]); > } else { > - spin_unlock_bh(&rtlpriv->locks.waitq_lock); > + spin_unlock(&rtlpriv->locks.waitq_lock); > break; > } > - spin_unlock_bh(&rtlpriv->locks.waitq_lock); > + spin_unlock(&rtlpriv->locks.waitq_lock); > > /* Some macaddr can't do early mode. like > * multicast/broadcast/no_qos data The mail subject should be 'rtlwifi: move ....', and the other looks good to me. Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thank you so much for your useful advice. Pkshih <pkshih@realtek.com> 于2019年3月20日周三 上午10:31写道： > > On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote: > > It is unnecessary to call spin_lock_bh in a tasklet. > > > > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> > > > > --- > > drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c > > b/drivers/net/wireless/realtek/rtlwifi/pci.c > > index 48ca521..4055e0a 100644 > > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c > > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c > > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw > > *hw) > > > > memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc)); > > > > - spin_lock_bh(&rtlpriv->locks.waitq_lock); > > + spin_lock(&rtlpriv->locks.waitq_lock); > > if (!skb_queue_empty(&mac->skb_waitq[tid]) && > > (ring->entries - skb_queue_len(&ring->queue) > > > rtlhal->max_earlymode_num)) { > > skb = skb_dequeue(&mac->skb_waitq[tid]); > > } else { > > - spin_unlock_bh(&rtlpriv->locks.waitq_lock); > > + spin_unlock(&rtlpriv->locks.waitq_lock); > > break; > > } > > - spin_unlock_bh(&rtlpriv->locks.waitq_lock); > > + spin_unlock(&rtlpriv->locks.waitq_lock); > > > > /* Some macaddr can't do early mode. like > > * multicast/broadcast/no_qos data > > The mail subject should be 'rtlwifi: move ....', and the other looks good to me. > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > >
Jeff Xie <chongguiguzi@gmail.com> wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers-next.git, thanks. 38bb0baea310 rtlwifi: move spin_lock_bh to spin_lock in tasklet
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c index 48ca521..4055e0a 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw *hw) memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc)); - spin_lock_bh(&rtlpriv->locks.waitq_lock); + spin_lock(&rtlpriv->locks.waitq_lock); if (!skb_queue_empty(&mac->skb_waitq[tid]) && (ring->entries - skb_queue_len(&ring->queue) > rtlhal->max_earlymode_num)) { skb = skb_dequeue(&mac->skb_waitq[tid]); } else { - spin_unlock_bh(&rtlpriv->locks.waitq_lock); + spin_unlock(&rtlpriv->locks.waitq_lock); break; } - spin_unlock_bh(&rtlpriv->locks.waitq_lock); + spin_unlock(&rtlpriv->locks.waitq_lock); /* Some macaddr can't do early mode. like * multicast/broadcast/no_qos data
It is unnecessary to call spin_lock_bh in a tasklet. Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)