| Message ID | 4f7160cb9f52335ce15fccac087fec25e7650884.1556255852.git.ryder.lee@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Felix Fietkau |
| Headers | show |
| Series | [v2] mt76: mt7615: add TX/RX antenna pattern capabilities | expand |
On 2019-04-26 07:23, Ryder Lee wrote: > Announce antenna pattern cap to adapt PHY and baseband settings. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > Changes since v2: > - Add a prefix mt76 in the title. > --- > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > index 3ab3ff553ef2..122f7a565540 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > @@ -190,6 +190,8 @@ int mt7615_register_device(struct mt7615_dev *dev) > IEEE80211_VHT_CAP_SHORT_GI_160 | > IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_11454 | > IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK | > + IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN | > + IEEE80211_VHT_CAP_TX_ANTENNA_PATTERN | If I read the standard correctly, these flags indicate that the rx/tx antenna pattern does NOT change during association. Doesn't that mean that we should set it in mac80211.c instead, so that it also applies to MT76x2? Thanks, - Felix
On Tue, 2019-04-30 at 11:24 +0200, Felix Fietkau wrote: > On 2019-04-26 07:23, Ryder Lee wrote: > > Announce antenna pattern cap to adapt PHY and baseband settings. > > > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > --- > > Changes since v2: > > - Add a prefix mt76 in the title. > > --- > > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > index 3ab3ff553ef2..122f7a565540 100644 > > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > @@ -190,6 +190,8 @@ int mt7615_register_device(struct mt7615_dev *dev) > > IEEE80211_VHT_CAP_SHORT_GI_160 | > > IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_11454 | > > IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK | > > + IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN | > > + IEEE80211_VHT_CAP_TX_ANTENNA_PATTERN | > If I read the standard correctly, these flags indicate that the rx/tx > antenna pattern does NOT change during association. > Doesn't that mean that we should set it in mac80211.c instead, so that > it also applies to MT76x2? > Right. I will add these flags in common code. Ryder
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c index 3ab3ff553ef2..122f7a565540 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c @@ -190,6 +190,8 @@ int mt7615_register_device(struct mt7615_dev *dev) IEEE80211_VHT_CAP_SHORT_GI_160 | IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_11454 | IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK | + IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN | + IEEE80211_VHT_CAP_TX_ANTENNA_PATTERN | IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ; dev->mt76.chainmask = 0x404; dev->mt76.antenna_mask = 0xf;
Announce antenna pattern cap to adapt PHY and baseband settings. Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> --- Changes since v2: - Add a prefix mt76 in the title. --- drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 ++ 1 file changed, 2 insertions(+)