| Message ID | 20190304222841.13899-12-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce the generic ECC engine abstraction | expand |
On Mon, 4 Mar 2019 23:28:16 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Fix a probable copy/paste error: the function works like > mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/mtdcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index 21e3cdc04036..6ed48018163c 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes); > * @start: first ECC byte to set > * @nbytes: number of ECC bytes to set Looks like the parameter descriptions are wrong too. > * > - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes. > + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes. > * > * Returns zero on success, a negative error code otherwise. > */
Hi Boris, Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 31 Mar 2019 13:32:46 +0200: > On Mon, 4 Mar 2019 23:28:16 +0100 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > Fix a probable copy/paste error: the function works like > > mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/mtd/mtdcore.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > > index 21e3cdc04036..6ed48018163c 100644 > > --- a/drivers/mtd/mtdcore.c > > +++ b/drivers/mtd/mtdcore.c > > @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes); > > * @start: first ECC byte to set > > * @nbytes: number of ECC bytes to set > > Looks like the parameter descriptions are wrong too. Are you sure? I don't see where. > > > * > > - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes. > > + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes. > > * > > * Returns zero on success, a negative error code otherwise. > > */ > Thanks, Miquèl
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 21e3cdc04036..6ed48018163c 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes); * @start: first ECC byte to set * @nbytes: number of ECC bytes to set * - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes. + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes. * * Returns zero on success, a negative error code otherwise. */
Fix a probable copy/paste error: the function works like mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)