| Message ID | 20190509073150.13027-1-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails | expand |
On 9.05.19 г. 10:31 ч., Qu Wenruo wrote: > At the context of btrfs_run_delalloc_range(), we haven't started/joined > a transaction, thus even something went wrong, we can't and won't abort > transaction, thus no way to make the fs RO. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/extent_io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 13fca7bfc1f2..85023bb322f0 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode, > } > ret = btrfs_run_delalloc_range(inode, page, delalloc_start, > delalloc_end, &page_started, nr_written, wbc); > - /* File system has been set read-only */ > if (ret) { > SetPageError(page); > /* >
On Thu, May 09, 2019 at 03:31:50PM +0800, Qu Wenruo wrote: > At the context of btrfs_run_delalloc_range(), we haven't started/joined > a transaction, thus even something went wrong, we can't and won't abort > transaction, thus no way to make the fs RO. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Added to 5.3 queue, thanks.
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 13fca7bfc1f2..85023bb322f0 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode, } ret = btrfs_run_delalloc_range(inode, page, delalloc_start, delalloc_end, &page_started, nr_written, wbc); - /* File system has been set read-only */ if (ret) { SetPageError(page); /*
At the context of btrfs_run_delalloc_range(), we haven't started/joined a transaction, thus even something went wrong, we can't and won't abort transaction, thus no way to make the fs RO. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/btrfs/extent_io.c | 1 - 1 file changed, 1 deletion(-)