| Message ID | 1546582221-143220-1-git-send-email-chi-hsien.lin@cypress.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [1/6] nl80211: add NL80211_ATTR_IFINDEX to port authorized event | expand |
On 1/4/2019 7:11 AM, Chi-Hsien Lin wrote: > From: Chung-Hsien Hsu <stanley.hsu@cypress.com> > > Add NL80211_ATTR_IFINDEX attribute to port authorized event to indicate > the operating interface of the device. > > Signed-off-by: Chung-Hsien Hsu <stanley.hsu@cypress.com> > Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com> > --- > net/wireless/nl80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index 5e49492d5911..594aeba2982a 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -14727,7 +14727,8 @@ void nl80211_send_port_authorized(struct cfg80211_registered_device *rdev, > return; > } > > - if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) > + if (nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex) || > + nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) > goto nla_put_failure; Maybe also put NL80211_ATTR_WIPHY in the notification to be consistent with the other MLME notifications. Regards, Arend
Please resend this entire set addressing the comments you already got. johannes
On Fri, Jan 04, 2019 at 11:51:19AM +0100, Arend Van Spriel wrote: > On 1/4/2019 7:11 AM, Chi-Hsien Lin wrote: > >From: Chung-Hsien Hsu <stanley.hsu@cypress.com> > > > >Add NL80211_ATTR_IFINDEX attribute to port authorized event to indicate > >the operating interface of the device. > > > >Signed-off-by: Chung-Hsien Hsu <stanley.hsu@cypress.com> > >Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com> > >--- > > net/wireless/nl80211.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > >index 5e49492d5911..594aeba2982a 100644 > >--- a/net/wireless/nl80211.c > >+++ b/net/wireless/nl80211.c > >@@ -14727,7 +14727,8 @@ void nl80211_send_port_authorized(struct cfg80211_registered_device *rdev, > > return; > > } > >-if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) > >+if (nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex) || > >+ nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) > > goto nla_put_failure; > > Maybe also put NL80211_ATTR_WIPHY in the notification to be > consistent with the other MLME notifications. Thanks for the comment. Will include it in V2. Regards, Chung-Hsien > > Regards, > Arend This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 5e49492d5911..594aeba2982a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -14727,7 +14727,8 @@ void nl80211_send_port_authorized(struct cfg80211_registered_device *rdev, return; } - if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) + if (nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex) || + nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) goto nla_put_failure; genlmsg_end(msg, hdr);