| Message ID | 20190418163733.17414-2-jeff.dagenais@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | [1/2] thermal: generic-adc: make lookup table optional | expand |
Hello, On Thu, Apr 18, 2019 at 12:37:33PM -0400, Jean-Francois Dagenais wrote: I added a description to this patch, but next time, on your next patches, describe your change. Description is not an optional field of a commit, it is very mandatory! BR, > Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com> > --- > .../devicetree/bindings/thermal/thermal-generic-adc.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt b/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt > index d72355502b78..691a09db2fef 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt > @@ -8,16 +8,22 @@ temperature using voltage-temperature lookup table. > Required properties: > =================== > - compatible: Must be "generic-adc-thermal". > +- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description > + of this property. > +Optional properties: > +=================== > - temperature-lookup-table: Two dimensional array of Integer; lookup table > to map the relation between ADC value and > temperature. When ADC is read, the value is > looked up on the table to get the equivalent > temperature. > + > The first value of the each row of array is the > temperature in milliCelsius and second value of > the each row of array is the ADC read value. > -- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description > - of this property. > + > + If not specified, driver assumes the ADC channel > + gives milliCelsius directly. > > Example : > #include <dt-bindings/thermal/thermal.h>
diff --git a/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt b/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt index d72355502b78..691a09db2fef 100644 --- a/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt +++ b/Documentation/devicetree/bindings/thermal/thermal-generic-adc.txt @@ -8,16 +8,22 @@ temperature using voltage-temperature lookup table. Required properties: =================== - compatible: Must be "generic-adc-thermal". +- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description + of this property. +Optional properties: +=================== - temperature-lookup-table: Two dimensional array of Integer; lookup table to map the relation between ADC value and temperature. When ADC is read, the value is looked up on the table to get the equivalent temperature. + The first value of the each row of array is the temperature in milliCelsius and second value of the each row of array is the ADC read value. -- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description - of this property. + + If not specified, driver assumes the ADC channel + gives milliCelsius directly. Example : #include <dt-bindings/thermal/thermal.h>
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com> --- .../devicetree/bindings/thermal/thermal-generic-adc.txt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)