| Message ID | 20190523235543.4342-1-delphij@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Use user supplied origin name for extension.partialcone instead of hardcoded value. | expand |
Xin Li wrote: > Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value. Good catch! Nits: - s/partialcone/partialclone/ (missing "l") - subject lines in git.git tend to be of the form "subsystem: lowercase summary" with no trailing period. So maybe something like: clone: respect user supplied origin name when setting up partial clone > Signed-off-by: Xin Li <delphij@google.com> > --- > builtin/clone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The change looks obviously good. With or without a commit message change like suggested above, Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Thanks.
diff --git a/builtin/clone.c b/builtin/clone.c index 50bde99618..822208a346 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix) remote_head_points_at, &branch_top); if (filter_options.choice) - partial_clone_register("origin", &filter_options); + partial_clone_register(option_origin, &filter_options); if (is_local) clone_local(path, git_dir);
Signed-off-by: Xin Li <delphij@google.com> --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)