mbox series

[00/16] wilc1000: move out of staging

Message ID 1549696298-9795-1-git-send-email-ajay.kathat@microchip.com (mailing list archive)
Headers show
Series wilc1000: move out of staging | expand

Message

Ajay Singh Feb. 9, 2019, 7:12 a.m. UTC
From: Ajay Singh <ajay.kathat@microchip.com>

This patch series is to review and move wilc1000 driver out of staging.
Implemented the initial received review comments[1] and submitting the
driver again. During this cleanup deleted around 3.3k lines of code.

Below are the major items fixed in recent cleanup:
 - remove use of shadow buffer to keep scan result.
 - remove internal messaging flow to handle cfg80211_ops.
 - make use of cfg80211 provided API.
 - use structure for packing firmware commands.
 - make use of kernel provided API and macros.
 - remove unnecessary logs messages.

Pending action item:
 - dynamically add/remove p2p interface.

 This item will take some time, we are planning to take it up after
 mainline.

 We hope it can be move out staging in v5.1.
 Please review and confirm if it is good to move out.

[1]. https://www.spinics.net/lists/linux-wireless/msg177877.html

Ajay Singh (16):
  wilc1000: add host_interface.h
  wilc1000: add host_interface.c
  wilc1000: add wilc_wlan_if.h
  wilc1000: add wilc_wlan_cfg.h
  wilc1000: add wilc_wlan_cfg.c
  wilc1000: add wilc_wfi_netdevice.h
  wilc1000: add wilc_wfi_cfgoperations.h
  wilc1000: add wilc_wfi_cfgoperations.c
  wilc1000: add wilc_netdev.c
  wilc1000: add wilc_mon.c
  wilc1000: add wilc_spi.c
  wilc1000: add wilc_wlan.c
  wilc1000: add wilc_wlan.h
  wilc1000: add wilc_sdio.c
  wilc1000: updated DT device binding for wilc1000 device
  wilc1000: add Makefile and Kconfig files for wilc1000 compilation

 .../net/wireless}/microchip,wilc1000,sdio.txt      |    0
 .../net/wireless}/microchip,wilc1000,spi.txt       |    0
 drivers/net/wireless/Kconfig                       |    1 +
 drivers/net/wireless/Makefile                      |    1 +
 drivers/net/wireless/microchip/Kconfig             |   14 +
 drivers/net/wireless/microchip/Makefile            |    2 +
 drivers/net/wireless/microchip/wilc1000/Kconfig    |   42 +
 drivers/net/wireless/microchip/wilc1000/Makefile   |   14 +
 .../wireless/microchip/wilc1000/host_interface.c   | 2152 ++++++++++++++++++++
 .../wireless/microchip/wilc1000/host_interface.h   |  247 +++
 drivers/net/wireless/microchip/wilc1000/wilc_mon.c |  258 +++
 .../net/wireless/microchip/wilc1000/wilc_netdev.c  | 1079 ++++++++++
 .../net/wireless/microchip/wilc1000/wilc_sdio.c    | 1140 +++++++++++
 drivers/net/wireless/microchip/wilc1000/wilc_spi.c | 1136 +++++++++++
 .../microchip/wilc1000/wilc_wfi_cfgoperations.c    | 1878 +++++++++++++++++
 .../microchip/wilc1000/wilc_wfi_cfgoperations.h    |   24 +
 .../microchip/wilc1000/wilc_wfi_netdevice.h        |  292 +++
 .../net/wireless/microchip/wilc1000/wilc_wlan.c    | 1346 ++++++++++++
 .../net/wireless/microchip/wilc1000/wilc_wlan.h    |  313 +++
 .../wireless/microchip/wilc1000/wilc_wlan_cfg.c    |  495 +++++
 .../wireless/microchip/wilc1000/wilc_wlan_cfg.h    |   54 +
 .../net/wireless/microchip/wilc1000/wilc_wlan_if.h |  803 ++++++++
 drivers/staging/Kconfig                            |    2 -
 drivers/staging/Makefile                           |    1 -
 24 files changed, 11291 insertions(+), 3 deletions(-)
 rename {drivers/staging/wilc1000 => Documentation/devicetree/bindings/net/wireless}/microchip,wilc1000,sdio.txt (100%)
 rename {drivers/staging/wilc1000 => Documentation/devicetree/bindings/net/wireless}/microchip,wilc1000,spi.txt (100%)
 create mode 100644 drivers/net/wireless/microchip/Kconfig
 create mode 100644 drivers/net/wireless/microchip/Makefile
 create mode 100644 drivers/net/wireless/microchip/wilc1000/Kconfig
 create mode 100644 drivers/net/wireless/microchip/wilc1000/Makefile
 create mode 100644 drivers/net/wireless/microchip/wilc1000/host_interface.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/host_interface.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_mon.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_netdev.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_sdio.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_spi.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_cfgoperations.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_cfgoperations.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_netdevice.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_cfg.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_cfg.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_if.h

Comments

Ajay Singh March 21, 2019, 12:49 p.m. UTC | #1
Hi Kalle/Johannes,

On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
> 
> This patch series is to review and move wilc1000 driver out of staging.
> Implemented the initial received review comments[1] and submitting the
> driver again. During this cleanup deleted around 3.3k lines of code.
> 
> Below are the major items fixed in recent cleanup:
>  - remove use of shadow buffer to keep scan result.
>  - remove internal messaging flow to handle cfg80211_ops.
>  - make use of cfg80211 provided API.
>  - use structure for packing firmware commands.
>  - make use of kernel provided API and macros.
>  - remove unnecessary logs messages.
> 
> Pending action item:
>  - dynamically add/remove p2p interface.
> 
>  This item will take some time, we are planning to take it up after
>  mainline.
> 
>  We hope it can be move out staging in v5.1.
>  Please review and confirm if it is good to move out.

Do you have any update for this series. Please provide your inputs for
next step.

Regards,
Ajay

> 
> [1]. https://www.spinics.net/lists/linux-wireless/msg177877.html
> 
> Ajay Singh (16):
>   wilc1000: add host_interface.h
>   wilc1000: add host_interface.c
>   wilc1000: add wilc_wlan_if.h
>   wilc1000: add wilc_wlan_cfg.h
>   wilc1000: add wilc_wlan_cfg.c
>   wilc1000: add wilc_wfi_netdevice.h
>   wilc1000: add wilc_wfi_cfgoperations.h
>   wilc1000: add wilc_wfi_cfgoperations.c
>   wilc1000: add wilc_netdev.c
>   wilc1000: add wilc_mon.c
>   wilc1000: add wilc_spi.c
>   wilc1000: add wilc_wlan.c
>   wilc1000: add wilc_wlan.h
>   wilc1000: add wilc_sdio.c
>   wilc1000: updated DT device binding for wilc1000 device
>   wilc1000: add Makefile and Kconfig files for wilc1000 compilation
> 
>  .../net/wireless}/microchip,wilc1000,sdio.txt      |    0
>  .../net/wireless}/microchip,wilc1000,spi.txt       |    0
>  drivers/net/wireless/Kconfig                       |    1 +
>  drivers/net/wireless/Makefile                      |    1 +
>  drivers/net/wireless/microchip/Kconfig             |   14 +
>  drivers/net/wireless/microchip/Makefile            |    2 +
>  drivers/net/wireless/microchip/wilc1000/Kconfig    |   42 +
>  drivers/net/wireless/microchip/wilc1000/Makefile   |   14 +
>  .../wireless/microchip/wilc1000/host_interface.c   | 2152 ++++++++++++++++++++
>  .../wireless/microchip/wilc1000/host_interface.h   |  247 +++
>  drivers/net/wireless/microchip/wilc1000/wilc_mon.c |  258 +++
>  .../net/wireless/microchip/wilc1000/wilc_netdev.c  | 1079 ++++++++++
>  .../net/wireless/microchip/wilc1000/wilc_sdio.c    | 1140 +++++++++++
>  drivers/net/wireless/microchip/wilc1000/wilc_spi.c | 1136 +++++++++++
>  .../microchip/wilc1000/wilc_wfi_cfgoperations.c    | 1878 +++++++++++++++++
>  .../microchip/wilc1000/wilc_wfi_cfgoperations.h    |   24 +
>  .../microchip/wilc1000/wilc_wfi_netdevice.h        |  292 +++
>  .../net/wireless/microchip/wilc1000/wilc_wlan.c    | 1346 ++++++++++++
>  .../net/wireless/microchip/wilc1000/wilc_wlan.h    |  313 +++
>  .../wireless/microchip/wilc1000/wilc_wlan_cfg.c    |  495 +++++
>  .../wireless/microchip/wilc1000/wilc_wlan_cfg.h    |   54 +
>  .../net/wireless/microchip/wilc1000/wilc_wlan_if.h |  803 ++++++++
>  drivers/staging/Kconfig                            |    2 -
>  drivers/staging/Makefile                           |    1 -
>  24 files changed, 11291 insertions(+), 3 deletions(-)
>  rename {drivers/staging/wilc1000 => Documentation/devicetree/bindings/net/wireless}/microchip,wilc1000,sdio.txt (100%)
>  rename {drivers/staging/wilc1000 => Documentation/devicetree/bindings/net/wireless}/microchip,wilc1000,spi.txt (100%)
>  create mode 100644 drivers/net/wireless/microchip/Kconfig
>  create mode 100644 drivers/net/wireless/microchip/Makefile
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/Kconfig
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/Makefile
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/host_interface.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/host_interface.h
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_mon.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_netdev.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_sdio.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_spi.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_cfgoperations.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_cfgoperations.h
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wfi_netdevice.h
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan.h
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_cfg.c
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_cfg.h
>  create mode 100644 drivers/net/wireless/microchip/wilc1000/wilc_wlan_if.h
>
Kalle Valo March 21, 2019, 12:54 p.m. UTC | #2
<Ajay.Kathat@microchip.com> writes:

> Hi Kalle/Johannes,
>
> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>> From: Ajay Singh <ajay.kathat@microchip.com>
>> 
>> This patch series is to review and move wilc1000 driver out of staging.
>> Implemented the initial received review comments[1] and submitting the
>> driver again. During this cleanup deleted around 3.3k lines of code.
>> 
>> Below are the major items fixed in recent cleanup:
>>  - remove use of shadow buffer to keep scan result.
>>  - remove internal messaging flow to handle cfg80211_ops.
>>  - make use of cfg80211 provided API.
>>  - use structure for packing firmware commands.
>>  - make use of kernel provided API and macros.
>>  - remove unnecessary logs messages.
>> 
>> Pending action item:
>>  - dynamically add/remove p2p interface.
>> 
>>  This item will take some time, we are planning to take it up after
>>  mainline.
>> 
>>  We hope it can be move out staging in v5.1.
>>  Please review and confirm if it is good to move out.
>
> Do you have any update for this series. Please provide your inputs for
> next step.

rtw88 is taking priority in the new drivers "queue" so I doubt I can
take a look at this in the next few weeks.
Ajay Singh March 21, 2019, 2:06 p.m. UTC | #3
On 3/21/2019 6:24 PM, Kalle Valo wrote:
> 
> <Ajay.Kathat@microchip.com> writes:
> 
>> Hi Kalle/Johannes,
>>
>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>
>>> This patch series is to review and move wilc1000 driver out of staging.
>>> Implemented the initial received review comments[1] and submitting the
>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>
>>> Below are the major items fixed in recent cleanup:
>>>  - remove use of shadow buffer to keep scan result.
>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>  - make use of cfg80211 provided API.
>>>  - use structure for packing firmware commands.
>>>  - make use of kernel provided API and macros.
>>>  - remove unnecessary logs messages.
>>>
>>> Pending action item:
>>>  - dynamically add/remove p2p interface.
>>>
>>>  This item will take some time, we are planning to take it up after
>>>  mainline.
>>>
>>>  We hope it can be move out staging in v5.1.
>>>  Please review and confirm if it is good to move out.
>>
>> Do you have any update for this series. Please provide your inputs for
>> next step.
> 
> rtw88 is taking priority in the new drivers "queue" so I doubt I can
> take a look at this in the next few weeks.
> 

Thanks Kalle. I will wait for your next update.

Regards,
Ajay
Ajay Singh May 23, 2019, 1:32 p.m. UTC | #4
Hi Kalle,

On 3/21/2019 6:24 PM, Kalle Valo wrote:
> 
> <Ajay.Kathat@microchip.com> writes:
> 
>> Hi Kalle/Johannes,
>>
>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>
>>> This patch series is to review and move wilc1000 driver out of staging.
>>> Implemented the initial received review comments[1] and submitting the
>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>
>>> Below are the major items fixed in recent cleanup:
>>>  - remove use of shadow buffer to keep scan result.
>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>  - make use of cfg80211 provided API.
>>>  - use structure for packing firmware commands.
>>>  - make use of kernel provided API and macros.
>>>  - remove unnecessary logs messages.
>>>
>>> Pending action item:
>>>  - dynamically add/remove p2p interface.
>>>
>>>  This item will take some time, we are planning to take it up after
>>>  mainline.
>>>
>>>  We hope it can be move out staging in v5.1.
>>>  Please review and confirm if it is good to move out.
>>
>> Do you have any update for this series. Please provide your inputs for
>> next step.
> 
> rtw88 is taking priority in the new drivers "queue" so I doubt I can
> take a look at this in the next few weeks.
> 

Is there any update for wilc1000 driver review. Please let me know your
inputs.

Regards,
Ajay
Kalle Valo May 23, 2019, 2:13 p.m. UTC | #5
<Ajay.Kathat@microchip.com> writes:

> Hi Kalle,
>
> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>> 
>> <Ajay.Kathat@microchip.com> writes:
>> 
>>> Hi Kalle/Johannes,
>>>
>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>
>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>> Implemented the initial received review comments[1] and submitting the
>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>
>>>> Below are the major items fixed in recent cleanup:
>>>>  - remove use of shadow buffer to keep scan result.
>>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>>  - make use of cfg80211 provided API.
>>>>  - use structure for packing firmware commands.
>>>>  - make use of kernel provided API and macros.
>>>>  - remove unnecessary logs messages.
>>>>
>>>> Pending action item:
>>>>  - dynamically add/remove p2p interface.
>>>>
>>>>  This item will take some time, we are planning to take it up after
>>>>  mainline.
>>>>
>>>>  We hope it can be move out staging in v5.1.
>>>>  Please review and confirm if it is good to move out.
>>>
>>> Do you have any update for this series. Please provide your inputs for
>>> next step.
>> 
>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>> take a look at this in the next few weeks.
>> 
>
> Is there any update for wilc1000 driver review. Please let me know your
> inputs.

So is the driver in good shape now? I really do not want to use a lot of
time reviewing it just to find out that there's a lot of work to do. For
example, has someone else reviewed it?
Ajay Singh May 23, 2019, 4:45 p.m. UTC | #6
Hi Kalle,

On 5/23/2019 7:43 PM, Kalle Valo wrote:
> <Ajay.Kathat@microchip.com> writes:
> 
>> Hi Kalle,
>>
>> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>>>
>>> <Ajay.Kathat@microchip.com> writes:
>>>
>>>> Hi Kalle/Johannes,
>>>>
>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>>
>>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>>> Implemented the initial received review comments[1] and submitting the
>>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>>
>>>>> Below are the major items fixed in recent cleanup:
>>>>>  - remove use of shadow buffer to keep scan result.
>>>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>>>  - make use of cfg80211 provided API.
>>>>>  - use structure for packing firmware commands.
>>>>>  - make use of kernel provided API and macros.
>>>>>  - remove unnecessary logs messages.
>>>>>
>>>>> Pending action item:
>>>>>  - dynamically add/remove p2p interface.
>>>>>
>>>>>  This item will take some time, we are planning to take it up after
>>>>>  mainline.
>>>>>
>>>>>  We hope it can be move out staging in v5.1.
>>>>>  Please review and confirm if it is good to move out.
>>>>
>>>> Do you have any update for this series. Please provide your inputs for
>>>> next step.
>>>
>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>>> take a look at this in the next few weeks.
>>>
>>
>> Is there any update for wilc1000 driver review. Please let me know your
>> inputs.
> 
> So is the driver in good shape now? I really do not want to use a lot of
> time reviewing it just to find out that there's a lot of work to do. For
> example, has someone else reviewed it?
> 

The first series for complete driver review was submitted earlier [1].
It was reviewed by Johannes and he looked into driver integration with
the cfg80211 stack part. We worked on the review comments and submitted
the changes to staging.

We need further review to identify if there is any blocker to move to
mainline.

[1]. https://www.spinics.net/lists/linux-wireless/msg177878.html

Regards,
Ajay
Ajay Singh May 31, 2019, 4:53 a.m. UTC | #7
Hi Kalle,

On 5/23/2019 10:15 PM, Ajay.Kathat@microchip.com wrote:
> Hi Kalle,
> 
> On 5/23/2019 7:43 PM, Kalle Valo wrote:
>> <Ajay.Kathat@microchip.com> writes:
>>
>>> Hi Kalle,
>>>
>>> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>>>>
>>>> <Ajay.Kathat@microchip.com> writes:
>>>>
>>>>> Hi Kalle/Johannes,
>>>>>
>>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>>>
>>>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>>>> Implemented the initial received review comments[1] and submitting the
>>>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>>>
>>>>>> Below are the major items fixed in recent cleanup:
>>>>>>  - remove use of shadow buffer to keep scan result.
>>>>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>>>>  - make use of cfg80211 provided API.
>>>>>>  - use structure for packing firmware commands.
>>>>>>  - make use of kernel provided API and macros.
>>>>>>  - remove unnecessary logs messages.
>>>>>>
>>>>>> Pending action item:
>>>>>>  - dynamically add/remove p2p interface.
>>>>>>
>>>>>>  This item will take some time, we are planning to take it up after
>>>>>>  mainline.
>>>>>>
>>>>>>  We hope it can be move out staging in v5.1.
>>>>>>  Please review and confirm if it is good to move out.
>>>>>
>>>>> Do you have any update for this series. Please provide your inputs for
>>>>> next step.
>>>>
>>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>>>> take a look at this in the next few weeks.
>>>>
>>>
>>> Is there any update for wilc1000 driver review. Please let me know your
>>> inputs.
>>
>> So is the driver in good shape now? I really do not want to use a lot of
>> time reviewing it just to find out that there's a lot of work to do. For
>> example, has someone else reviewed it?
>>
> 
> The first series for complete driver review was submitted earlier [1].
> It was reviewed by Johannes and he looked into driver integration with
> the cfg80211 stack part. We worked on the review comments and submitted
> the changes to staging.
> 
> We need further review to identify if there is any blocker to move to
> mainline.
> 
> [1]. https://www.spinics.net/lists/linux-wireless/msg177878.html
> 

Just a gentle mail to check if wilc1000 driver is picked-up for review
and what is the next step.


Regards,
Ajay
Kalle Valo May 31, 2019, 6:23 a.m. UTC | #8
<Ajay.Kathat@microchip.com> writes:

> Hi Kalle,
>
> On 5/23/2019 10:15 PM, Ajay.Kathat@microchip.com wrote:
>> Hi Kalle,
>> 
>> On 5/23/2019 7:43 PM, Kalle Valo wrote:
>>> <Ajay.Kathat@microchip.com> writes:
>>>
>>>> Hi Kalle,
>>>>
>>>> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>>>>>
>>>>> <Ajay.Kathat@microchip.com> writes:
>>>>>
>>>>>> Hi Kalle/Johannes,
>>>>>>
>>>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>>>>
>>>>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>>>>> Implemented the initial received review comments[1] and submitting the
>>>>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>>>>
>>>>>>> Below are the major items fixed in recent cleanup:
>>>>>>>  - remove use of shadow buffer to keep scan result.
>>>>>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>>>>>  - make use of cfg80211 provided API.
>>>>>>>  - use structure for packing firmware commands.
>>>>>>>  - make use of kernel provided API and macros.
>>>>>>>  - remove unnecessary logs messages.
>>>>>>>
>>>>>>> Pending action item:
>>>>>>>  - dynamically add/remove p2p interface.
>>>>>>>
>>>>>>>  This item will take some time, we are planning to take it up after
>>>>>>>  mainline.
>>>>>>>
>>>>>>>  We hope it can be move out staging in v5.1.
>>>>>>>  Please review and confirm if it is good to move out.
>>>>>>
>>>>>> Do you have any update for this series. Please provide your inputs for
>>>>>> next step.
>>>>>
>>>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>>>>> take a look at this in the next few weeks.
>>>>>
>>>>
>>>> Is there any update for wilc1000 driver review. Please let me know your
>>>> inputs.
>>>
>>> So is the driver in good shape now? I really do not want to use a lot of
>>> time reviewing it just to find out that there's a lot of work to do. For
>>> example, has someone else reviewed it?
>>>
>> 
>> The first series for complete driver review was submitted earlier [1].
>> It was reviewed by Johannes and he looked into driver integration with
>> the cfg80211 stack part. We worked on the review comments and submitted
>> the changes to staging.
>> 
>> We need further review to identify if there is any blocker to move to
>> mainline.
>> 
>> [1]. https://www.spinics.net/lists/linux-wireless/msg177878.html
>> 
>
> Just a gentle mail to check if wilc1000 driver is picked-up for review
> and what is the next step.

Please be patient, getting a driver upstream is not a simple task. What
this driver needs now is reviews and people saying that the driver is
ready for upstream, I have not seen any of that yet. Maybe you could
submit a new version, hopefully that triggers people to review this?
Also I'll try to find time for review but, as usual, I'm really busy.
Ajay Singh May 31, 2019, 7:11 a.m. UTC | #9
On 5/31/2019 11:53 AM, Kalle Valo wrote:
> External E-Mail
> 
> 
> <Ajay.Kathat@microchip.com> writes:
> 
>> Hi Kalle,
>>
>> On 5/23/2019 10:15 PM, Ajay.Kathat@microchip.com wrote:
>>> Hi Kalle,
>>>
>>> On 5/23/2019 7:43 PM, Kalle Valo wrote:
>>>> <Ajay.Kathat@microchip.com> writes:
>>>>
>>>>> Hi Kalle,
>>>>>
>>>>> On 3/21/2019 6:24 PM, Kalle Valo wrote:
>>>>>>
>>>>>> <Ajay.Kathat@microchip.com> writes:
>>>>>>
>>>>>>> Hi Kalle/Johannes,
>>>>>>>
>>>>>>> On 2/9/2019 12:42 PM, Ajay Kathat - I15481 wrote:
>>>>>>>> From: Ajay Singh <ajay.kathat@microchip.com>
>>>>>>>>
>>>>>>>> This patch series is to review and move wilc1000 driver out of staging.
>>>>>>>> Implemented the initial received review comments[1] and submitting the
>>>>>>>> driver again. During this cleanup deleted around 3.3k lines of code.
>>>>>>>>
>>>>>>>> Below are the major items fixed in recent cleanup:
>>>>>>>>  - remove use of shadow buffer to keep scan result.
>>>>>>>>  - remove internal messaging flow to handle cfg80211_ops.
>>>>>>>>  - make use of cfg80211 provided API.
>>>>>>>>  - use structure for packing firmware commands.
>>>>>>>>  - make use of kernel provided API and macros.
>>>>>>>>  - remove unnecessary logs messages.
>>>>>>>>
>>>>>>>> Pending action item:
>>>>>>>>  - dynamically add/remove p2p interface.
>>>>>>>>
>>>>>>>>  This item will take some time, we are planning to take it up after
>>>>>>>>  mainline.
>>>>>>>>
>>>>>>>>  We hope it can be move out staging in v5.1.
>>>>>>>>  Please review and confirm if it is good to move out.
>>>>>>>
>>>>>>> Do you have any update for this series. Please provide your inputs for
>>>>>>> next step.
>>>>>>
>>>>>> rtw88 is taking priority in the new drivers "queue" so I doubt I can
>>>>>> take a look at this in the next few weeks.
>>>>>>
>>>>>
>>>>> Is there any update for wilc1000 driver review. Please let me know your
>>>>> inputs.
>>>>
>>>> So is the driver in good shape now? I really do not want to use a lot of
>>>> time reviewing it just to find out that there's a lot of work to do. For
>>>> example, has someone else reviewed it?
>>>>
>>>
>>> The first series for complete driver review was submitted earlier [1].
>>> It was reviewed by Johannes and he looked into driver integration with
>>> the cfg80211 stack part. We worked on the review comments and submitted
>>> the changes to staging.
>>>
>>> We need further review to identify if there is any blocker to move to
>>> mainline.
>>>
>>> [1]. https://www.spinics.net/lists/linux-wireless/msg177878.html
>>>
>>
>> Just a gentle mail to check if wilc1000 driver is picked-up for review
>> and what is the next step.
> 
> Please be patient, getting a driver upstream is not a simple task. What
> this driver needs now is reviews and people saying that the driver is
> ready for upstream, I have not seen any of that yet. Maybe you could
> submit a new version, hopefully that triggers people to review this?
> Also I'll try to find time for review but, as usual, I'm really busy.
> 

Thanks Kalle, I will wait for review comments and in the meantime I will
send the patch update.

Regards,
Ajay