| Message ID | 20190531191204.4044-4-palmer@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] Non-functional cleanup of a "__user * filename" | expand |
On Fri, May 31, 2019 at 9:23 PM Palmer Dabbelt <palmer@sifive.com> wrote: > > Signed-off-by: Palmer Dabbelt <palmer@sifive.com> As usual, each patch needs a changelog text. I would prefer having a single patch here that changes /all/ system call tables at once, rather than doing one at a time like we used to. In linux-next, we are at number 434 now, and there are a couple of other new system calls being proposed right now (more than usual), so you may have to change the number a few times. Note: most architectures use .tbl files now, the exceptions are include/uapi/asm-generic/unistd.h and arch/arm64/include/asm/unistd32.h, and the latter also requires changing __NR_compat_syscalls in asm/unistd.h. Numbers should now be the same across architectures, except for alpha, which has a +110 offset. We have discussed ways to have a single file to modify for a new call on all architectures, but no patches yet. Arnd
On Fri, 31 May 2019 12:56:39 PDT (-0700), Arnd Bergmann wrote: > On Fri, May 31, 2019 at 9:23 PM Palmer Dabbelt <palmer@sifive.com> wrote: >> >> Signed-off-by: Palmer Dabbelt <palmer@sifive.com> > > As usual, each patch needs a changelog text. I would prefer having a single > patch here that changes /all/ system call tables at once, rather than doing one > at a time like we used to. Works for me. That also gives me something to write about it the text :) > In linux-next, we are at number 434 now, and there are a couple of other > new system calls being proposed right now (more than usual), so you may > have to change the number a few times. OK, no problem. It'll be a bit easier to handle the number that way. > Note: most architectures use .tbl files now, the exceptions are > include/uapi/asm-generic/unistd.h and arch/arm64/include/asm/unistd32.h, > and the latter also requires changing __NR_compat_syscalls in asm/unistd.h. > > Numbers should now be the same across architectures, except for alpha, > which has a +110 offset. We have discussed ways to have a single > file to modify for a new call on all architectures, but no patches yet. OK, thanks. I'll wait a bit for feedback, but unless there's anything else I'll go ahead and finish this.
diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h index dee7292e1df6..f0f4cad4c416 100644 --- a/include/uapi/asm-generic/unistd.h +++ b/include/uapi/asm-generic/unistd.h @@ -833,8 +833,11 @@ __SYSCALL(__NR_io_uring_enter, sys_io_uring_enter) #define __NR_io_uring_register 427 __SYSCALL(__NR_io_uring_register, sys_io_uring_register) +#define __NR_fchmodat4 428 +__SYSCALL(__NR_fchmodat4, sys_fchmodat4) + #undef __NR_syscalls -#define __NR_syscalls 428 +#define __NR_syscalls 429 /* * 32 bit systems traditionally used different
Signed-off-by: Palmer Dabbelt <palmer@sifive.com> --- include/uapi/asm-generic/unistd.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)