| Message ID | 20190603142102.27191-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/bridge: sii902x: fix comparision of u32 with less than zero | expand |
On 03/06/2019 17:21, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The less than check for the variable num_lanes is always going to be > false because the variable is a u32. Fix this by making num_lanes an > int and also make loop index i an int too. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Oh, one of these slipped trough after all. Acked-by: Jyri Sarha <jsarha@ti.com> > --- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index d6f98d388ac2..21a947603c88 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, > .max_i2s_channels = 0, > }; > u8 lanes[4]; > - u32 num_lanes, i; > + int num_lanes, i; > > if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", >
On 03.06.2019 16:21, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The less than check for the variable num_lanes is always going to be > false because the variable is a u32. Fix this by making num_lanes an > int and also make loop index i an int too. > > Addresses-Coverity: ("Unsigned compared against 0") Is there a rule in Kernel of adding such tags? I have spotted only: Addresses-Coverity-ID? Beside this: Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index d6f98d388ac2..21a947603c88 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, > .max_i2s_channels = 0, > }; > u8 lanes[4]; > - u32 num_lanes, i; > + int num_lanes, i; > > if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",
On 07/06/2019 10:41, Andrzej Hajda wrote: > On 03.06.2019 16:21, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The less than check for the variable num_lanes is always going to be >> false because the variable is a u32. Fix this by making num_lanes an >> int and also make loop index i an int too. >> >> Addresses-Coverity: ("Unsigned compared against 0") > > > Is there a rule in Kernel of adding such tags? > > I have spotted only: Addresses-Coverity-ID? > Unfortunately I'm running a Coverity in-house and so the Coverity ID is not public, so it does not make sense for me to report the ID. Colin > > Beside this: > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > -- > Regards > Andrzej > > >> Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/gpu/drm/bridge/sii902x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c >> index d6f98d388ac2..21a947603c88 100644 >> --- a/drivers/gpu/drm/bridge/sii902x.c >> +++ b/drivers/gpu/drm/bridge/sii902x.c >> @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, >> .max_i2s_channels = 0, >> }; >> u8 lanes[4]; >> - u32 num_lanes, i; >> + int num_lanes, i; >> >> if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { >> dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", > >
On 03.06.2019 16:21, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The less than check for the variable num_lanes is always going to be > false because the variable is a u32. Fix this by making num_lanes an > int and also make loop index i an int too. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/bridge/sii902x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index d6f98d388ac2..21a947603c88 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, > .max_i2s_channels = 0, > }; > u8 lanes[4]; > - u32 num_lanes, i; > + int num_lanes, i; > > if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { > dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n", Queued to drm-misc-next. -- Regards Andrzej
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index d6f98d388ac2..21a947603c88 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -719,7 +719,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, .max_i2s_channels = 0, }; u8 lanes[4]; - u32 num_lanes, i; + int num_lanes, i; if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",