Message ID | 155862813755.26654.563679411147031501.stgit@warthog.procyon.org.uk (mailing list archive) |
---|---|
Headers | show |
Series | nfs: Mount API conversion | expand |
On Thu, May 23, 2019 at 05:19:05PM +0100, David Howells wrote: > out_no_data: > - dfprintk(MOUNT, "NFS: mount program didn't pass any mount data\n"); > - return -EINVAL; > + if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE) { > + ctx->skip_reconfig_option_check = true; > + return 0; > + } That really ought to be if (fc->root) { /* remount */ ctx->skip_reconfig_option_check = true; return 0; } and similar in the v4 counterpart. fc->purpose is a bad idea; it is possible to get rid of it. Frankly, I'm tempted to add static inline bool is_remount_fc(struct fs_context *fc) { return fc->root != NULL; } and just use that in such places...
Schumaker, Anna <Anna.Schumaker@netapp.com> wrote: > > 17 files changed, 1293 insertions(+), 1331 deletions(-) > > Can you please split this patch up? Um... Al and I have split it up somewhat. See the other 22 patches in the series ;-) Splitting it up further is going to be tricky because of the way stuff weaves around all over the place in fs/nfs/. I can have a go, but, for various reasons, I'm not going to have time to look at that till after the next merge window. I don't know whether SteveD has a sufficiently empty plate to offload that to him? > The mailing list dropped it because it's over 100,000 characters > (http://vger.kernel.org/majordomo-info.html#taboo) and I can't use the > version you sent directly to me because Office365 / Evolution keeps > converting tabs to spaces somewhere along the line. Note also this bit in the cover letter: The patches can be found here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git on branch: mount-api-nfs ;-) David