| Message ID | 20190610204927.2de21c9a@wiggum (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ssb/gpio: Remove unnecessary WARN_ON from driver_gpio | expand |
On 6/10/19 1:49 PM, Michael Büsch wrote: > The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. > The warning serves no purpose. So let's just remove it. > > Reported-by: H Buus <ubuntu@hbuus.com> > Signed-off-by: Michael Büsch <m@bues.ch> > > --- Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Larry > > diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c > index e809dae4c470..66a76fd83248 100644 > --- a/drivers/ssb/driver_gpio.c > +++ b/drivers/ssb/driver_gpio.c > @@ -460,9 +460,6 @@ int ssb_gpio_init(struct ssb_bus *bus) > return ssb_gpio_chipco_init(bus); > else if (ssb_extif_available(&bus->extif)) > return ssb_gpio_extif_init(bus); > - else > - WARN_ON(1); > - > return -1; > } > > @@ -472,9 +469,6 @@ int ssb_gpio_unregister(struct ssb_bus *bus) > ssb_extif_available(&bus->extif)) { > gpiochip_remove(&bus->gpio); > return 0; > - } else { > - WARN_ON(1); > } > - > return -1; > } >
On 6/10/2019 3:16 PM, Larry Finger wrote: > On 6/10/19 1:49 PM, Michael Büsch wrote: >> The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. >> The warning serves no purpose. So let's just remove it. >> >> Reported-by: H Buus <ubuntu@hbuus.com> >> Signed-off-by: Michael Büsch <m@bues.ch> >> >> --- > > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> > > Larry Works for me. Thanks! >> >> diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c >> index e809dae4c470..66a76fd83248 100644 >> --- a/drivers/ssb/driver_gpio.c >> +++ b/drivers/ssb/driver_gpio.c >> @@ -460,9 +460,6 @@ int ssb_gpio_init(struct ssb_bus *bus) >> return ssb_gpio_chipco_init(bus); >> else if (ssb_extif_available(&bus->extif)) >> return ssb_gpio_extif_init(bus); >> - else >> - WARN_ON(1); >> - >> return -1; >> } >> @@ -472,9 +469,6 @@ int ssb_gpio_unregister(struct ssb_bus *bus) >> ssb_extif_available(&bus->extif)) { >> gpiochip_remove(&bus->gpio); >> return 0; >> - } else { >> - WARN_ON(1); >> } >> - >> return -1; >> } >> >
Michael Büsch <m@bues.ch> writes: > The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. > The warning serves no purpose. So let's just remove it. > > Reported-by: H Buus <ubuntu@hbuus.com> > Signed-off-by: Michael Büsch <m@bues.ch> For some reason patchwork (or pwcli script) didn't like this patch so manually applied to wireless-drivers-next: e73e43246da6 ssb/gpio: Remove unnecessary WARN_ON from driver_gpio I have a faint recollection that I had a similar problem with another patch from Michael, did we ever conclude what was the issue?
On Tue, 25 Jun 2019 at 12:06, Kalle Valo <kvalo@codeaurora.org> wrote: > > Michael Büsch <m@bues.ch> writes: > > > The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. > > The warning serves no purpose. So let's just remove it. > > > > Reported-by: H Buus <ubuntu@hbuus.com> > > Signed-off-by: Michael Büsch <m@bues.ch> > > For some reason patchwork (or pwcli script) didn't like this patch so > manually applied to wireless-drivers-next: > > e73e43246da6 ssb/gpio: Remove unnecessary WARN_ON from driver_gpio > > I have a faint recollection that I had a similar problem with another > patch from Michael, did we ever conclude what was the issue? Yes [1], a bug in kernel.org's version of patchwork. The fix was included in v2.1.1; latest is v2.1.3. kernel.org is (still) at v2.1.0. Maybe it's time to poke helpdesk? Regards Jonas [1] https://marc.info/?l=linux-wireless&m=153388992528252&w=2
Jonas Gorski <jonas.gorski@gmail.com> writes: > On Tue, 25 Jun 2019 at 12:06, Kalle Valo <kvalo@codeaurora.org> wrote: >> >> Michael Büsch <m@bues.ch> writes: >> >> > The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. >> > The warning serves no purpose. So let's just remove it. >> > >> > Reported-by: H Buus <ubuntu@hbuus.com> >> > Signed-off-by: Michael Büsch <m@bues.ch> >> >> For some reason patchwork (or pwcli script) didn't like this patch so >> manually applied to wireless-drivers-next: >> >> e73e43246da6 ssb/gpio: Remove unnecessary WARN_ON from driver_gpio >> >> I have a faint recollection that I had a similar problem with another >> patch from Michael, did we ever conclude what was the issue? > > Yes [1], a bug in kernel.org's version of patchwork. Ah, that was it. Thanks! > The fix was included in v2.1.1; latest is v2.1.3. kernel.org is > (still) at v2.1.0. Maybe it's time to poke helpdesk? Indeed, that would be a good idea. Apparently v2.1.0 was released a year ago: https://github.com/getpatchwork/patchwork/releases So if your or anyone else has time, please do report to kernel.org helpdesk and hopefully they can help.
diff --git a/drivers/ssb/driver_gpio.c b/drivers/ssb/driver_gpio.c index e809dae4c470..66a76fd83248 100644 --- a/drivers/ssb/driver_gpio.c +++ b/drivers/ssb/driver_gpio.c @@ -460,9 +460,6 @@ int ssb_gpio_init(struct ssb_bus *bus) return ssb_gpio_chipco_init(bus); else if (ssb_extif_available(&bus->extif)) return ssb_gpio_extif_init(bus); - else - WARN_ON(1); - return -1; } @@ -472,9 +469,6 @@ int ssb_gpio_unregister(struct ssb_bus *bus) ssb_extif_available(&bus->extif)) { gpiochip_remove(&bus->gpio); return 0; - } else { - WARN_ON(1); } - return -1; }
The WARN_ON triggers on older BCM4401-B0 100Base-TX ethernet controllers. The warning serves no purpose. So let's just remove it. Reported-by: H Buus <ubuntu@hbuus.com> Signed-off-by: Michael Büsch <m@bues.ch> ---