| Message ID | 1862877.fiP6YxjBP5@devpool35 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: remove unused barrier defines | expand |
On Mon, 17 Jun 2019, Rolf Eike Beer wrote: > From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001 > From: Rolf Eike Beer <eb@emlix.com> > Date: Mon, 17 Jun 2019 14:22:37 +0200 > Subject: [PATCH] riscv: remove unused barrier defines > > They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long after > 2e39465abc4b7856a0ea6fcf4f6b4668bb5db877 removed the remnants of all previous > instances from the tree. > > Signed-off-by: Rolf Eike Beer <eb@emlix.com> Thanks for the patch. checkpatch.pl flags an error on the format of the commit IDs in the patch description. And there is also the spurious mbox header. These have been fixed these up here, and the patch below has been queued for v5.2-rc. It would help to run "checkpatch.pl --strict" on future patches. thanks again, - Paul From: Rolf Eike Beer <eb@emlix.com> Date: Mon, 17 Jun 2019 14:25:59 +0200 Subject: [PATCH] riscv: remove unused barrier defines They were introduced in commit fab957c11efe ("RISC-V: Atomic and Locking Code") long after commit 2e39465abc4b ("locking: Remove deprecated smp_mb__() barriers") removed the remnants of all previous instances from the tree. Signed-off-by: Rolf Eike Beer <eb@emlix.com> [paul.walmsley@sifive.com: stripped spurious mbox header from patch description; fixed commit references in patch header] Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com> --- arch/riscv/include/asm/bitops.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h index f30daf26f08f..01db98dfd043 100644 --- a/arch/riscv/include/asm/bitops.h +++ b/arch/riscv/include/asm/bitops.h @@ -23,11 +23,6 @@ #include <asm/barrier.h> #include <asm/bitsperlong.h> -#ifndef smp_mb__before_clear_bit -#define smp_mb__before_clear_bit() smp_mb() -#define smp_mb__after_clear_bit() smp_mb() -#endif /* smp_mb__before_clear_bit */ - #include <asm-generic/bitops/__ffs.h> #include <asm-generic/bitops/ffz.h> #include <asm-generic/bitops/fls.h>
diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h index 3943be480af0..396a3303c537 100644 --- a/arch/riscv/include/asm/bitops.h +++ b/arch/riscv/include/asm/bitops.h @@ -15,11 +15,6 @@ #include <asm/barrier.h> #include <asm/bitsperlong.h> -#ifndef smp_mb__before_clear_bit -#define smp_mb__before_clear_bit() smp_mb() -#define smp_mb__after_clear_bit() smp_mb() -#endif /* smp_mb__before_clear_bit */ - #include <asm-generic/bitops/__ffs.h> #include <asm-generic/bitops/ffz.h> #include <asm-generic/bitops/fls.h>