| Message ID | 20190618180206.4908-1-mmaddireddy@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable Tegra PCIe root port features | expand |
On Tue, Jun 18, 2019 at 11:31:39PM +0530, Manikanta Maddireddy wrote: > This series of patches adds, > - Tegra root port features like Gen2, AER, etc > - Power and perf optimizations > - Fixes like "power up sequence", "dev_err prints", etc > > This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 > based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms. > > Changes from V5 to V6: > - Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk > > Changes from V4 to V5: > - Patch [V4, 4/28]: Added blank line before block style comment > - Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up" > patch is dropped > - Patch [V4, 27/28]: > * Updated reset gpio toggle logic to reflect active low usage > * Replaced kasprintf() with devm_kasprintf() > * Updated commit message with more information. > > Changes from V3 to V4: > - Patch [V3,27/29] is dropped > - Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in > pci-tegra driver instead of of_get_pci* wrapper function defined in > Patch [V3,27/29]. > > Manikanta Maddireddy (27): > soc/tegra: pmc: Export tegra_powergate_power_on() > PCI: tegra: Handle failure cases in tegra_pcie_power_on() > PCI: tegra: Rearrange Tegra PCIe driver functions > PCI: tegra: Mask AFI_INTR in runtime suspend > PCI: tegra: Fix PCIe host power up sequence > PCI: tegra: Add PCIe Gen2 link speed support > PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability > PCI: tegra: Program UPHY electrical settings for Tegra210 > PCI: tegra: Enable opportunistic UpdateFC and ACK > PCI: tegra: Disable AFI dynamic clock gating > PCI: tegra: Process pending DLL transactions before entering L1 or L2 > PCI: tegra: Enable PCIe xclk clock clamping > PCI: tegra: Increase the deskew retry time > PCI: tegra: Add SW fixup for RAW violations > PCI: tegra: Update flow control timer frequency in Tegra210 > PCI: tegra: Set target speed as Gen1 before starting LTSSM > PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal > PCI: tegra: Program AFI_CACHE* registers only for Tegra20 > PCI: tegra: Change PRSNT_SENSE IRQ log to debug > PCI: tegra: Disable MSI for Tegra PCIe root port > PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct > dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop > arm64: tegra: Add PEX DPD states as pinctrl properties > PCI: tegra: Put PEX CLK & BIAS pads in DPD mode > PCI: Add DT binding for "reset-gpios" property > PCI: tegra: Add support for GPIO based PERST# > PCI: tegra: Change link retry log level to debug Hi Lorenzo, Bjorn, There's a build-time dependency from the PCI patches on patch 1 of this series. I've already Acked that, so I think you should take it through the PCI tree along with the rest of the series. The only patch that I picked up is the DT change in patch 23, which is decoupled from the others via DT, though the data that it adds to DT will be used in patch 24. Does that sound good to you? Thierry > > .../bindings/pci/nvidia,tegra20-pcie.txt | 8 + > Documentation/devicetree/bindings/pci/pci.txt | 3 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 + > drivers/pci/controller/pci-tegra.c | 578 +++++++++++++++--- > drivers/pci/quirks.c | 39 ++ > drivers/soc/tegra/pmc.c | 1 + > 6 files changed, 568 insertions(+), 80 deletions(-) > > -- > 2.17.1 >
On Thu, Jun 20, 2019 at 12:25:52PM +0200, Thierry Reding wrote: > On Tue, Jun 18, 2019 at 11:31:39PM +0530, Manikanta Maddireddy wrote: > > This series of patches adds, > > - Tegra root port features like Gen2, AER, etc > > - Power and perf optimizations > > - Fixes like "power up sequence", "dev_err prints", etc > > > > This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 > > based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms. > > > > Changes from V5 to V6: > > - Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk > > > > Changes from V4 to V5: > > - Patch [V4, 4/28]: Added blank line before block style comment > > - Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up" > > patch is dropped > > - Patch [V4, 27/28]: > > * Updated reset gpio toggle logic to reflect active low usage > > * Replaced kasprintf() with devm_kasprintf() > > * Updated commit message with more information. > > > > Changes from V3 to V4: > > - Patch [V3,27/29] is dropped > > - Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in > > pci-tegra driver instead of of_get_pci* wrapper function defined in > > Patch [V3,27/29]. > > > > Manikanta Maddireddy (27): > > soc/tegra: pmc: Export tegra_powergate_power_on() > > PCI: tegra: Handle failure cases in tegra_pcie_power_on() > > PCI: tegra: Rearrange Tegra PCIe driver functions > > PCI: tegra: Mask AFI_INTR in runtime suspend > > PCI: tegra: Fix PCIe host power up sequence > > PCI: tegra: Add PCIe Gen2 link speed support > > PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability > > PCI: tegra: Program UPHY electrical settings for Tegra210 > > PCI: tegra: Enable opportunistic UpdateFC and ACK > > PCI: tegra: Disable AFI dynamic clock gating > > PCI: tegra: Process pending DLL transactions before entering L1 or L2 > > PCI: tegra: Enable PCIe xclk clock clamping > > PCI: tegra: Increase the deskew retry time > > PCI: tegra: Add SW fixup for RAW violations > > PCI: tegra: Update flow control timer frequency in Tegra210 > > PCI: tegra: Set target speed as Gen1 before starting LTSSM > > PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal > > PCI: tegra: Program AFI_CACHE* registers only for Tegra20 > > PCI: tegra: Change PRSNT_SENSE IRQ log to debug > > PCI: tegra: Disable MSI for Tegra PCIe root port > > PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct > > dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop > > arm64: tegra: Add PEX DPD states as pinctrl properties > > PCI: tegra: Put PEX CLK & BIAS pads in DPD mode > > PCI: Add DT binding for "reset-gpios" property > > PCI: tegra: Add support for GPIO based PERST# > > PCI: tegra: Change link retry log level to debug > > Hi Lorenzo, Bjorn, > > There's a build-time dependency from the PCI patches on patch 1 of this > series. I've already Acked that, so I think you should take it through > the PCI tree along with the rest of the series. > > The only patch that I picked up is the DT change in patch 23, which is > decoupled from the others via DT, though the data that it adds to DT > will be used in patch 24. > > Does that sound good to you? Yes, I will drop patch 20 too as requested. Is there a merge ordering dependency between patch 23 and 24 ? If yes we should let Bjorn know or you drop patch 23 and I will merge it via PCI, let us know. Lorenzo > Thierry > > > > > .../bindings/pci/nvidia,tegra20-pcie.txt | 8 + > > Documentation/devicetree/bindings/pci/pci.txt | 3 + > > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 + > > drivers/pci/controller/pci-tegra.c | 578 +++++++++++++++--- > > drivers/pci/quirks.c | 39 ++ > > drivers/soc/tegra/pmc.c | 1 + > > 6 files changed, 568 insertions(+), 80 deletions(-) > > > > -- > > 2.17.1 > >
On Thu, Jun 20, 2019 at 11:53:01AM +0100, Lorenzo Pieralisi wrote: > On Thu, Jun 20, 2019 at 12:25:52PM +0200, Thierry Reding wrote: > > On Tue, Jun 18, 2019 at 11:31:39PM +0530, Manikanta Maddireddy wrote: > > > This series of patches adds, > > > - Tegra root port features like Gen2, AER, etc > > > - Power and perf optimizations > > > - Fixes like "power up sequence", "dev_err prints", etc > > > > > > This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 > > > based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms. > > > > > > Changes from V5 to V6: > > > - Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk > > > > > > Changes from V4 to V5: > > > - Patch [V4, 4/28]: Added blank line before block style comment > > > - Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up" > > > patch is dropped > > > - Patch [V4, 27/28]: > > > * Updated reset gpio toggle logic to reflect active low usage > > > * Replaced kasprintf() with devm_kasprintf() > > > * Updated commit message with more information. > > > > > > Changes from V3 to V4: > > > - Patch [V3,27/29] is dropped > > > - Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in > > > pci-tegra driver instead of of_get_pci* wrapper function defined in > > > Patch [V3,27/29]. > > > > > > Manikanta Maddireddy (27): > > > soc/tegra: pmc: Export tegra_powergate_power_on() > > > PCI: tegra: Handle failure cases in tegra_pcie_power_on() > > > PCI: tegra: Rearrange Tegra PCIe driver functions > > > PCI: tegra: Mask AFI_INTR in runtime suspend > > > PCI: tegra: Fix PCIe host power up sequence > > > PCI: tegra: Add PCIe Gen2 link speed support > > > PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability > > > PCI: tegra: Program UPHY electrical settings for Tegra210 > > > PCI: tegra: Enable opportunistic UpdateFC and ACK > > > PCI: tegra: Disable AFI dynamic clock gating > > > PCI: tegra: Process pending DLL transactions before entering L1 or L2 > > > PCI: tegra: Enable PCIe xclk clock clamping > > > PCI: tegra: Increase the deskew retry time > > > PCI: tegra: Add SW fixup for RAW violations > > > PCI: tegra: Update flow control timer frequency in Tegra210 > > > PCI: tegra: Set target speed as Gen1 before starting LTSSM > > > PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal > > > PCI: tegra: Program AFI_CACHE* registers only for Tegra20 > > > PCI: tegra: Change PRSNT_SENSE IRQ log to debug > > > PCI: tegra: Disable MSI for Tegra PCIe root port > > > PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct > > > dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop > > > arm64: tegra: Add PEX DPD states as pinctrl properties > > > PCI: tegra: Put PEX CLK & BIAS pads in DPD mode > > > PCI: Add DT binding for "reset-gpios" property > > > PCI: tegra: Add support for GPIO based PERST# > > > PCI: tegra: Change link retry log level to debug > > > > Hi Lorenzo, Bjorn, > > > > There's a build-time dependency from the PCI patches on patch 1 of this > > series. I've already Acked that, so I think you should take it through > > the PCI tree along with the rest of the series. > > > > The only patch that I picked up is the DT change in patch 23, which is > > decoupled from the others via DT, though the data that it adds to DT > > will be used in patch 24. > > > > Does that sound good to you? > > Yes, I will drop patch 20 too as requested. Is there a merge ordering > dependency between patch 23 and 24 ? If yes we should let Bjorn know > or you drop patch 23 and I will merge it via PCI, let us know. Nope, I don't think there are any issues with ordering. Patch 23 basically just adds the DT content that will be used by patch 24 to dynamically change the pinmux options. Without patch 24, the default state will be applied, which is what the state will be on boot anyway. Patch 24 without patch 23 would mean that the PCI driver will try to select a pinctrl state which does not exist, but this is already handled gracefully in pinctrl_pm_select_state(). Thierry
On Tue, Jun 18, 2019 at 11:31:39PM +0530, Manikanta Maddireddy wrote: > This series of patches adds, > - Tegra root port features like Gen2, AER, etc > - Power and perf optimizations > - Fixes like "power up sequence", "dev_err prints", etc > > This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 > based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms. > > Changes from V5 to V6: > - Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk > > Changes from V4 to V5: > - Patch [V4, 4/28]: Added blank line before block style comment > - Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up" > patch is dropped > - Patch [V4, 27/28]: > * Updated reset gpio toggle logic to reflect active low usage > * Replaced kasprintf() with devm_kasprintf() > * Updated commit message with more information. > > Changes from V3 to V4: > - Patch [V3,27/29] is dropped > - Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in > pci-tegra driver instead of of_get_pci* wrapper function defined in > Patch [V3,27/29]. > > Manikanta Maddireddy (27): > soc/tegra: pmc: Export tegra_powergate_power_on() > PCI: tegra: Handle failure cases in tegra_pcie_power_on() > PCI: tegra: Rearrange Tegra PCIe driver functions > PCI: tegra: Mask AFI_INTR in runtime suspend > PCI: tegra: Fix PCIe host power up sequence > PCI: tegra: Add PCIe Gen2 link speed support > PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability > PCI: tegra: Program UPHY electrical settings for Tegra210 > PCI: tegra: Enable opportunistic UpdateFC and ACK > PCI: tegra: Disable AFI dynamic clock gating > PCI: tegra: Process pending DLL transactions before entering L1 or L2 > PCI: tegra: Enable PCIe xclk clock clamping > PCI: tegra: Increase the deskew retry time > PCI: tegra: Add SW fixup for RAW violations > PCI: tegra: Update flow control timer frequency in Tegra210 > PCI: tegra: Set target speed as Gen1 before starting LTSSM > PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal > PCI: tegra: Program AFI_CACHE* registers only for Tegra20 > PCI: tegra: Change PRSNT_SENSE IRQ log to debug > PCI: tegra: Disable MSI for Tegra PCIe root port > PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct > dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop > arm64: tegra: Add PEX DPD states as pinctrl properties > PCI: tegra: Put PEX CLK & BIAS pads in DPD mode > PCI: Add DT binding for "reset-gpios" property > PCI: tegra: Add support for GPIO based PERST# > PCI: tegra: Change link retry log level to debug > > .../bindings/pci/nvidia,tegra20-pcie.txt | 8 + > Documentation/devicetree/bindings/pci/pci.txt | 3 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 + > drivers/pci/controller/pci-tegra.c | 578 +++++++++++++++--- > drivers/pci/quirks.c | 39 ++ > drivers/soc/tegra/pmc.c | 1 + > 6 files changed, 568 insertions(+), 80 deletions(-) Applied with exceptions discussed to pci/tegra for v5.3, please have a thorough look and report back if I am missing something. Thanks, Lorenzo
On 20-Jun-19 10:16 PM, Lorenzo Pieralisi wrote: > On Tue, Jun 18, 2019 at 11:31:39PM +0530, Manikanta Maddireddy wrote: >> This series of patches adds, >> - Tegra root port features like Gen2, AER, etc >> - Power and perf optimizations >> - Fixes like "power up sequence", "dev_err prints", etc >> >> This series of patches are tested on Tegra186 based Jetson-TX2, Tegra210 >> based Jetson-TX1, T124 based Jetson-TK1, Tegra20 and Tegra30 platforms. >> >> Changes from V5 to V6: >> - Patch [V4, 20/27]: Replaced pcie_pme_disable_msi() with no_msi quirk >> >> Changes from V4 to V5: >> - Patch [V4, 4/28]: Added blank line before block style comment >> - Patch [V4, 22/28]: "Access endpoint config only if PCIe link is up" >> patch is dropped >> - Patch [V4, 27/28]: >> * Updated reset gpio toggle logic to reflect active low usage >> * Replaced kasprintf() with devm_kasprintf() >> * Updated commit message with more information. >> >> Changes from V3 to V4: >> - Patch [V3,27/29] is dropped >> - Patch [V3,28/29]: devm_gpiod_get_from_of_node() is directly used in >> pci-tegra driver instead of of_get_pci* wrapper function defined in >> Patch [V3,27/29]. >> >> Manikanta Maddireddy (27): >> soc/tegra: pmc: Export tegra_powergate_power_on() >> PCI: tegra: Handle failure cases in tegra_pcie_power_on() >> PCI: tegra: Rearrange Tegra PCIe driver functions >> PCI: tegra: Mask AFI_INTR in runtime suspend >> PCI: tegra: Fix PCIe host power up sequence >> PCI: tegra: Add PCIe Gen2 link speed support >> PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability >> PCI: tegra: Program UPHY electrical settings for Tegra210 >> PCI: tegra: Enable opportunistic UpdateFC and ACK >> PCI: tegra: Disable AFI dynamic clock gating >> PCI: tegra: Process pending DLL transactions before entering L1 or L2 >> PCI: tegra: Enable PCIe xclk clock clamping >> PCI: tegra: Increase the deskew retry time >> PCI: tegra: Add SW fixup for RAW violations >> PCI: tegra: Update flow control timer frequency in Tegra210 >> PCI: tegra: Set target speed as Gen1 before starting LTSSM >> PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal >> PCI: tegra: Program AFI_CACHE* registers only for Tegra20 >> PCI: tegra: Change PRSNT_SENSE IRQ log to debug >> PCI: tegra: Disable MSI for Tegra PCIe root port >> PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct >> dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop >> arm64: tegra: Add PEX DPD states as pinctrl properties >> PCI: tegra: Put PEX CLK & BIAS pads in DPD mode >> PCI: Add DT binding for "reset-gpios" property >> PCI: tegra: Add support for GPIO based PERST# >> PCI: tegra: Change link retry log level to debug >> >> .../bindings/pci/nvidia,tegra20-pcie.txt | 8 + >> Documentation/devicetree/bindings/pci/pci.txt | 3 + >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 + >> drivers/pci/controller/pci-tegra.c | 578 +++++++++++++++--- >> drivers/pci/quirks.c | 39 ++ >> drivers/soc/tegra/pmc.c | 1 + >> 6 files changed, 568 insertions(+), 80 deletions(-) > Applied with exceptions discussed to pci/tegra for v5.3, please > have a thorough look and report back if I am missing something. > > Thanks, > Lorenzo All required patches are merged. Thank you