| Message ID | 20190726100614.6924-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 937a194ae8651b434c4b4c62fe94099f41a93e14 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ipw2x00: remove redundant assignment to err | expand |
On 26/07/2019, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable err is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine, thanks! Stanislav.
Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable err is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. 937a194ae865 ipw2x00: remove redundant assignment to err
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c index 75c0c29d81f0..8dfbaff2d1fe 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c @@ -4413,7 +4413,7 @@ static void ipw2100_kill_works(struct ipw2100_priv *priv) static int ipw2100_tx_allocate(struct ipw2100_priv *priv) { - int i, j, err = -EINVAL; + int i, j, err; void *v; dma_addr_t p;