| Message ID | 20190730125412.1446-1-johannes@sipsolutions.net (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" | expand |
On Tue, 30 Jul 2019 14:54:11 +0200, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Revert this for now, it has been reported multiple times that it > completely breaks connectivity on various devices. > > Cc: stable@vger.kernel.org > Fixes: 8dbb000ee73b ("mac80211: set NETIF_F_LLTX when using intermediate tx queues") > Reported-by: Jean Delvare <jdelvare@suse.de> > Reported-by: Peter Lebbing <peter@digitalbrains.com> > Signed-off-by: Johannes Berg <johannes.berg@intel.com> > --- > net/mac80211/iface.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c > index 06aac0aaae64..8dc6580e1787 100644 > --- a/net/mac80211/iface.c > +++ b/net/mac80211/iface.c > @@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev) > static void ieee80211_if_setup_no_queue(struct net_device *dev) > { > ieee80211_if_setup(dev); > - dev->features |= NETIF_F_LLTX; > dev->priv_flags |= IFF_NO_QUEUE; > } > Thanks Johannes. Tested-by: Jean Delvare <jdelvare@suse.de>
On 30/07/2019 14:54, Johannes Berg wrote: > Revert this for now, it has been reported multiple times that it > completely breaks connectivity on various devices. That was quick! Thank you! Peter.
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 06aac0aaae64..8dc6580e1787 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev) static void ieee80211_if_setup_no_queue(struct net_device *dev) { ieee80211_if_setup(dev); - dev->features |= NETIF_F_LLTX; dev->priv_flags |= IFF_NO_QUEUE; }