| Message ID | 20190807082556.5013-10-philippe.schenker@toradex.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Common patches from downstream development | expand |
On Wed, Aug 07, 2019 at 08:26:23AM +0000, Philippe Schenker wrote: > Add the phy-node and mdio bus to the fec-node, represented as is on > hardware. > This commit includes micrel,led-mode that is set to the default > value, prepared for someone who wants to change this. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > index 1beac22266ed..019dda6b88ad 100644 > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > @@ -140,7 +140,18 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rmii"; > + phy-handle = <ðphy>; > status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy: ethernet-phy@0 { > + reg = <0>; > + micrel,led-mode = <0>; Doesn't that need a compatible entry to be actually used? Best regards Uwe > >
On Wed, 2019-08-07 at 12:51 +0200, Uwe Kleine-König wrote: > On Wed, Aug 07, 2019 at 08:26:23AM +0000, Philippe Schenker wrote: > > Add the phy-node and mdio bus to the fec-node, represented as is on > > hardware. > > This commit includes micrel,led-mode that is set to the default > > value, prepared for someone who wants to change this. > > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > index 1beac22266ed..019dda6b88ad 100644 > > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > > @@ -140,7 +140,18 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_enet>; > > phy-mode = "rmii"; > > + phy-handle = <ðphy>; > > status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy: ethernet-phy@0 { > > + reg = <0>; > > + micrel,led-mode = <0>; > > Doesn't that need a compatible entry to be actually used? > > Best regards > Uwe Hi Uwe and thanks for pointing this out. I just tried it and it works fine without the compatible. Philippe > >
On Wed, 2019-08-07 at 08:26 +0000, Philippe Schenker wrote: > Add the phy-node and mdio bus to the fec-node, represented as is on > hardware. > This commit includes micrel,led-mode that is set to the default > value, prepared for someone who wants to change this. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > index 1beac22266ed..019dda6b88ad 100644 > --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi > @@ -140,7 +140,18 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rmii"; > + phy-handle = <ðphy>; > status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy: ethernet-phy@0 { > + reg = <0>; > + micrel,led-mode = <0>; > + }; > + }; > }; > > &hdmi {
diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index 1beac22266ed..019dda6b88ad 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -140,7 +140,18 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; + phy-handle = <ðphy>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy: ethernet-phy@0 { + reg = <0>; + micrel,led-mode = <0>; + }; + }; }; &hdmi {
Add the phy-node and mdio bus to the fec-node, represented as is on hardware. This commit includes micrel,led-mode that is set to the default value, prepared for someone who wants to change this. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- Changes in v3: None Changes in v2: None arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)