diff mbox series

drm/rockchip: fix VOP_WIN_GET macro

Message ID 20190703095111.29117-1-john@metanate.com (mailing list archive)
State New, archived
Headers show
Series drm/rockchip: fix VOP_WIN_GET macro | expand

Commit Message

John Keeping July 3, 2019, 9:51 a.m. UTC
Commit 9a61c54b9bff ("drm/rockchip: vop: group vop registers") seems to
have unintentionally changed the defintion of this macro.  Since it is
unused, this was not spotted but any attempt to use it results in
compilation errors.

Revert to the previous definition.

Fixes: 9a61c54b9bff ("drm/rockchip: vop: group vop registers")
Signed-off-by: John Keeping <john@metanate.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stübner Aug. 7, 2019, 10:48 p.m. UTC | #1
Am Mittwoch, 3. Juli 2019, 11:51:11 CEST schrieb John Keeping:
> Commit 9a61c54b9bff ("drm/rockchip: vop: group vop registers") seems to
> have unintentionally changed the defintion of this macro.  Since it is
> unused, this was not spotted but any attempt to use it results in
> compilation errors.
> 
> Revert to the previous definition.
> 
> Fixes: 9a61c54b9bff ("drm/rockchip: vop: group vop registers")
> Signed-off-by: John Keeping <john@metanate.com>

applied to drm-misc-next

Thanks
Heiko
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 09a790c2f3a1..a3430da3c008 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -79,7 +79,7 @@ 
 		vop_get_intr_type(vop, &vop->data->intr->name, type)
 
 #define VOP_WIN_GET(vop, win, name) \
-		vop_read_reg(vop, win->offset, win->phy->name)
+		vop_read_reg(vop, win->base, &win->phy->name)
 
 #define VOP_WIN_HAS_REG(win, name) \
 	(!!(win->phy->name.mask))