| Message ID | 20190808085139.21438-8-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: first tentative of conversion to yaml format | expand |
On Thu, Aug 8, 2019 at 10:54 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic G12A USB3 + PCIE Combo PHY over to a YAML schemas. > > While the original phy bindings specifies phy-supply as required, > the examples and implementations makes it optional, thus phy-supply > is not present in the properties and required lists. nit-pick: the original bindings didn't mention the phy-supply property at all I'm not sure if you have to re-send it, maybe this can be fixed up while applying? > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Hi, On 08/08/2019 21:50, Martin Blumenstingl wrote: > On Thu, Aug 8, 2019 at 10:54 AM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> Now that we have the DT validation in place, let's convert the device tree >> bindings for the Amlogic G12A USB3 + PCIE Combo PHY over to a YAML schemas. >> >> While the original phy bindings specifies phy-supply as required, >> the examples and implementations makes it optional, thus phy-supply >> is not present in the properties and required lists. > nit-pick: the original bindings didn't mention the phy-supply property at all > I'm not sure if you have to re-send it, maybe this can be fixed up > while applying? It didn't, but the phy.txt made it mandatory, but was optional in all examples and implementation, thus rob asked me to precise it in the commit log. Neil > >> Reviewed-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >
On Fri, Aug 9, 2019 at 9:00 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Hi, > > On 08/08/2019 21:50, Martin Blumenstingl wrote: > > On Thu, Aug 8, 2019 at 10:54 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > >> > >> Now that we have the DT validation in place, let's convert the device tree > >> bindings for the Amlogic G12A USB3 + PCIE Combo PHY over to a YAML schemas. > >> > >> While the original phy bindings specifies phy-supply as required, > >> the examples and implementations makes it optional, thus phy-supply > >> is not present in the properties and required lists. > > nit-pick: the original bindings didn't mention the phy-supply property at all > > I'm not sure if you have to re-send it, maybe this can be fixed up > > while applying? > > It didn't, but the phy.txt made it mandatory, but was optional in all examples > and implementation, thus rob asked me to precise it in the commit log. sorry, I missed that my Reviewed-by still stands - thanks for pointing it out (again)
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml new file mode 100644 index 000000000000..346f9c35427c --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 BayLibre, SAS +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson-g12a-usb3-pcie-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic G12A USB3 + PCIE Combo PHY + +maintainers: + - Neil Armstrong <narmstrong@baylibre.com> + +properties: + compatible: + enum: + - amlogic,meson-g12a-usb3-pcie-phy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: ref_clk + + resets: + maxItems: 1 + + reset-names: + items: + - const: phy + + "#phy-cells": + const: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - "#phy-cells" + +examples: + - | + phy@46000 { + compatible = "amlogic,meson-g12a-usb3-pcie-phy"; + reg = <0x46000 0x2000>; + clocks = <&ref_clk>; + clock-names = "ref_clk"; + resets = <&phy_reset>; + reset-names = "phy"; + #phy-cells = <1>; + }; diff --git a/Documentation/devicetree/bindings/phy/meson-g12a-usb3-pcie-phy.txt b/Documentation/devicetree/bindings/phy/meson-g12a-usb3-pcie-phy.txt deleted file mode 100644 index 7cfc17e2df31..000000000000 --- a/Documentation/devicetree/bindings/phy/meson-g12a-usb3-pcie-phy.txt +++ /dev/null @@ -1,22 +0,0 @@ -* Amlogic G12A USB3 + PCIE Combo PHY binding - -Required properties: -- compatible: Should be "amlogic,meson-g12a-usb3-pcie-phy" -- #phys-cells: must be 1. The cell number is used to select the phy mode - as defined in <dt-bindings/phy/phy.h> between PHY_TYPE_USB3 and PHY_TYPE_PCIE -- reg: The base address and length of the registers -- clocks: a phandle to the 100MHz reference clock of this PHY -- clock-names: must be "ref_clk" -- resets: phandle to the reset lines for the PHY control -- reset-names: must be "phy" - -Example: - usb3_pcie_phy: phy@46000 { - compatible = "amlogic,g12a-usb3-pcie-phy"; - reg = <0x0 0x46000 0x0 0x2000>; - clocks = <&clkc CLKID_PCIE_PLL>; - clock-names = "ref_clk"; - resets = <&reset RESET_PCIE_PHY>; - reset-names = "phy"; - #phy-cells = <1>; - };