| Message ID | 20190813023054.73126-2-gaoxiang25@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] staging: erofs: inline erofs_inode_is_data_compressed() | expand |
On 2019/8/13 10:30, Gao Xiang wrote: > cleancache was not fully implemented in EROFS. > In addition, it's tend to remove the whole cleancache in > related attempt [1]. > > [1] https://lore.kernel.org/linux-fsdevel/20190527103207.13287-3-jgross@suse.com/ > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks,
diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c index 75b859e48084..4cdb743c8b8d 100644 --- a/drivers/staging/erofs/data.c +++ b/drivers/staging/erofs/data.c @@ -201,12 +201,6 @@ static inline struct bio *erofs_read_raw_page(struct bio *bio, goto has_updated; } - if (cleancache_get_page(page) == 0) { - err = 0; - SetPageUptodate(page); - goto has_updated; - } - /* note that for readpage case, bio also equals to NULL */ if (bio && /* not continuous */ diff --git a/drivers/staging/erofs/internal.h b/drivers/staging/erofs/internal.h index 118e7c7e4d4d..4ce5991c381f 100644 --- a/drivers/staging/erofs/internal.h +++ b/drivers/staging/erofs/internal.h @@ -15,7 +15,6 @@ #include <linux/pagemap.h> #include <linux/bio.h> #include <linux/buffer_head.h> -#include <linux/cleancache.h> #include <linux/slab.h> #include <linux/vmalloc.h> #include "erofs_fs.h"
cleancache was not fully implemented in EROFS. In addition, it's tend to remove the whole cleancache in related attempt [1]. [1] https://lore.kernel.org/linux-fsdevel/20190527103207.13287-3-jgross@suse.com/ Signed-off-by: Gao Xiang <gaoxiang25@huawei.com> --- drivers/staging/erofs/data.c | 6 ------ drivers/staging/erofs/internal.h | 1 - 2 files changed, 7 deletions(-)