diff mbox series

drm/i915: add port info to debugfs

Message ID 20190821141554.18347-1-simon.ser@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: add port info to debugfs | expand

Commit Message

Ser, Simon Aug. 21, 2019, 2:15 p.m. UTC 
This patch adds a line with the port name to connectors in
debugfs/i916_display_info. A hint is printed if the port is type-C.

Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++++
 1 file changed, 9 insertions(+)

--
2.22.1

Comments

Imre Deak Aug. 21, 2019, 2:46 p.m. UTC | #1 
On Wed, Aug 21, 2019 at 05:15:54PM +0300, Simon Ser wrote:
> This patch adds a line with the port name to connectors in
> debugfs/i916_display_info. A hint is printed if the port is type-C.
> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index b39226d7f8d2..718a337c8f0a 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
>  static void intel_connector_info(struct seq_file *m,
>  				 struct drm_connector *connector)
>  {
> +	struct drm_i915_private *i915 = to_i915(connector->dev);
>  	struct intel_connector *intel_connector = to_intel_connector(connector);
>  	struct intel_encoder *intel_encoder = intel_connector->encoder;
>  	struct drm_display_mode *mode;
> +	enum tc_port tc_port;
> 
>  	seq_printf(m, "connector %d: type %s, status: %s\n",
>  		   connector->base.id, connector->name,
> @@ -2578,6 +2580,13 @@ static void intel_connector_info(struct seq_file *m,
>  	if (!intel_encoder)
>  		return;
> 
> +	if (intel_encoder->port != PORT_NONE) {
> +		tc_port = intel_port_to_tc(i915, intel_encoder->port);
> +		seq_printf(m, "\tport: %c%s\n",
> +			   port_name(intel_encoder->port),
> +			   tc_port != PORT_TC_NONE ? " (type-C)" : "");

for Type-C ports could you also print the type-C port index like

	port: C/TC#1

? See intel_tc_port_init().


> +	}
> +
>  	switch (connector->connector_type) {
>  	case DRM_MODE_CONNECTOR_DisplayPort:
>  	case DRM_MODE_CONNECTOR_eDP:
> --
> 2.22.1
>
Navare, Manasi Aug. 21, 2019, 4:31 p.m. UTC | #2 
On Wed, Aug 21, 2019 at 05:15:54PM +0300, Simon Ser wrote:
> This patch adds a line with the port name to connectors in
> debugfs/i916_display_info. A hint is printed if the port is type-C.

Typo here, should be i915_display_info

Manasi

> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index b39226d7f8d2..718a337c8f0a 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2557,9 +2557,11 @@ static void intel_lvds_info(struct seq_file *m,
>  static void intel_connector_info(struct seq_file *m,
>  				 struct drm_connector *connector)
>  {
> +	struct drm_i915_private *i915 = to_i915(connector->dev);
>  	struct intel_connector *intel_connector = to_intel_connector(connector);
>  	struct intel_encoder *intel_encoder = intel_connector->encoder;
>  	struct drm_display_mode *mode;
> +	enum tc_port tc_port;
> 
>  	seq_printf(m, "connector %d: type %s, status: %s\n",
>  		   connector->base.id, connector->name,
> @@ -2578,6 +2580,13 @@ static void intel_connector_info(struct seq_file *m,
>  	if (!intel_encoder)
>  		return;
> 
> +	if (intel_encoder->port != PORT_NONE) {
> +		tc_port = intel_port_to_tc(i915, intel_encoder->port);
> +		seq_printf(m, "\tport: %c%s\n",
> +			   port_name(intel_encoder->port),
> +			   tc_port != PORT_TC_NONE ? " (type-C)" : "");
> +	}
> +
>  	switch (connector->connector_type) {
>  	case DRM_MODE_CONNECTOR_DisplayPort:
>  	case DRM_MODE_CONNECTOR_eDP:
> --
> 2.22.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index b39226d7f8d2..718a337c8f0a 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2557,9 +2557,11 @@  static void intel_lvds_info(struct seq_file *m,
 static void intel_connector_info(struct seq_file *m,
 				 struct drm_connector *connector)
 {
+	struct drm_i915_private *i915 = to_i915(connector->dev);
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
 	struct drm_display_mode *mode;
+	enum tc_port tc_port;

 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, connector->name,
@@ -2578,6 +2580,13 @@  static void intel_connector_info(struct seq_file *m,
 	if (!intel_encoder)
 		return;

+	if (intel_encoder->port != PORT_NONE) {
+		tc_port = intel_port_to_tc(i915, intel_encoder->port);
+		seq_printf(m, "\tport: %c%s\n",
+			   port_name(intel_encoder->port),
+			   tc_port != PORT_TC_NONE ? " (type-C)" : "");
+	}
+
 	switch (connector->connector_type) {
 	case DRM_MODE_CONNECTOR_DisplayPort:
 	case DRM_MODE_CONNECTOR_eDP: