| Message ID | 20190830150756.21305-1-kw@linux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PCI: Move ATS declarations to linux/pci.h | expand |
On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > Move ATS function prototypes from include/linux/pci-ats.h to > include/linux/pci.h so users only need to include <linux/pci.h>: Why is that so important? Very few PCI(e) device drivers use ATS, so keeping it out of everyones include hell doesn't seem all bad.
On 30/08/2019 17:18, Christoph Hellwig wrote: > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: >> Move ATS function prototypes from include/linux/pci-ats.h to >> include/linux/pci.h so users only need to include <linux/pci.h>: > > Why is that so important? Very few PCI(e) device drivers use ATS, > so keeping it out of everyones include hell doesn't seem all bad. Although to be fair it seems that all the actual ATS stuff already moved out 4 years ago, so at the very least maybe it would warrant renaming to pci-pri-pasid.h :) Robin.
On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > Move ATS function prototypes from include/linux/pci-ats.h to > > include/linux/pci.h so users only need to include <linux/pci.h>: > > Why is that so important? Very few PCI(e) device drivers use ATS, > so keeping it out of everyones include hell doesn't seem all bad. This was my idea, and it wasn't a good one, sorry. The ATS, PRI, and PASID interfaces are all sort of related and are used only by the IOMMU drivers, so it probably makes sense to put them all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID stuff is in linux/pci-ats.h. Maybe the right thing would be to move the ATS stuff to pci-ats.h. I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: Move ATS declarations to linux/pci.h so they're all together") with the excuse of putting the external ATS interfaces next to pci_ats_init(). But that really looks like it was a mistake because pci_ats_init() is a PCI-internal thing and its declaration should probably be in drivers/pci/pci.h instead. There's also a useless "struct pci_ats" forward declaration in linux/pci.h that I should have removed with d544d75ac96a ("PCI: Embed ATS info directly into struct pci_dev"). Bjorn
[+cc Kelsey] On Mon, Sep 02, 2019 at 04:11:00PM -0500, Bjorn Helgaas wrote: > On Fri, Aug 30, 2019 at 09:18:40AM -0700, Christoph Hellwig wrote: > > On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote: > > > Move ATS function prototypes from include/linux/pci-ats.h to > > > include/linux/pci.h so users only need to include <linux/pci.h>: > > > > Why is that so important? Very few PCI(e) device drivers use ATS, > > so keeping it out of everyones include hell doesn't seem all bad. > > This was my idea, and it wasn't a good one, sorry. > > The ATS, PRI, and PASID interfaces are all sort of related and are > used only by the IOMMU drivers, so it probably makes sense to put them > all together. Right now the ATS stuff is in linux/pci.h and PRI/PASID > stuff is in linux/pci-ats.h. Maybe the right thing would be to move > the ATS stuff to pci-ats.h. > > I previously moved it from pci-ats.h to pci.h with ff9bee895c4d ("PCI: > Move ATS declarations to linux/pci.h so they're all together") with > the excuse of putting the external ATS interfaces next to > pci_ats_init(). But that really looks like it was a mistake because > pci_ats_init() is a PCI-internal thing and its declaration should > probably be in drivers/pci/pci.h instead. Never mind the pci_ats_init() part; Kelsey has already moved that: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=b92b512a435d
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 04a9f8443344..d43913386915 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -13,7 +13,6 @@ #include <linux/acpi.h> #include <linux/amba/bus.h> #include <linux/platform_device.h> -#include <linux/pci-ats.h> #include <linux/bitmap.h> #include <linux/slab.h> #include <linux/debugfs.h> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index 0ad6d34d1e96..3bd9455efc39 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -29,7 +29,6 @@ #include <linux/of_iommu.h> #include <linux/of_platform.h> #include <linux/pci.h> -#include <linux/pci-ats.h> #include <linux/platform_device.h> #include <linux/amba/bus.h> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 4658cda6f3d2..362845b5c88a 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -35,7 +35,6 @@ #include <linux/syscore_ops.h> #include <linux/tboot.h> #include <linux/dmi.h> -#include <linux/pci-ats.h> #include <linux/memblock.h> #include <linux/dma-contiguous.h> #include <linux/dma-direct.h> diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c index 040a445be300..f670315afa67 100644 --- a/drivers/iommu/intel-pasid.c +++ b/drivers/iommu/intel-pasid.c @@ -16,7 +16,6 @@ #include <linux/iommu.h> #include <linux/memory.h> #include <linux/pci.h> -#include <linux/pci-ats.h> #include <linux/spinlock.h> #include "intel-pasid.h" diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index 780de0caafe8..ee9dfc84f925 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -13,7 +13,6 @@ #include <linux/intel-svm.h> #include <linux/rculist.h> #include <linux/pci.h> -#include <linux/pci-ats.h> #include <linux/dmar.h> #include <linux/interrupt.h> #include <linux/mm_types.h> diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index e18499243f84..3f5fb2d4a763 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -10,7 +10,6 @@ */ #include <linux/export.h> -#include <linux/pci-ats.h> #include <linux/pci.h> #include <linux/slab.h> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f20a3de57d21..c8f2a05e6b37 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -29,7 +29,6 @@ #include <linux/pm_runtime.h> #include <linux/pci_hotplug.h> #include <linux/vmalloc.h> -#include <linux/pci-ats.h> #include <asm/setup.h> #include <asm/dma.h> #include <linux/aer.h> diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h deleted file mode 100644 index 1ebb88e7c184..000000000000 --- a/include/linux/pci-ats.h +++ /dev/null @@ -1,77 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef LINUX_PCI_ATS_H -#define LINUX_PCI_ATS_H - -#include <linux/pci.h> - -#ifdef CONFIG_PCI_PRI - -int pci_enable_pri(struct pci_dev *pdev, u32 reqs); -void pci_disable_pri(struct pci_dev *pdev); -void pci_restore_pri_state(struct pci_dev *pdev); -int pci_reset_pri(struct pci_dev *pdev); - -#else /* CONFIG_PCI_PRI */ - -static inline int pci_enable_pri(struct pci_dev *pdev, u32 reqs) -{ - return -ENODEV; -} - -static inline void pci_disable_pri(struct pci_dev *pdev) -{ -} - -static inline void pci_restore_pri_state(struct pci_dev *pdev) -{ -} - -static inline int pci_reset_pri(struct pci_dev *pdev) -{ - return -ENODEV; -} - -#endif /* CONFIG_PCI_PRI */ - -#ifdef CONFIG_PCI_PASID - -int pci_enable_pasid(struct pci_dev *pdev, int features); -void pci_disable_pasid(struct pci_dev *pdev); -void pci_restore_pasid_state(struct pci_dev *pdev); -int pci_pasid_features(struct pci_dev *pdev); -int pci_max_pasids(struct pci_dev *pdev); -int pci_prg_resp_pasid_required(struct pci_dev *pdev); - -#else /* CONFIG_PCI_PASID */ - -static inline int pci_enable_pasid(struct pci_dev *pdev, int features) -{ - return -EINVAL; -} - -static inline void pci_disable_pasid(struct pci_dev *pdev) -{ -} - -static inline void pci_restore_pasid_state(struct pci_dev *pdev) -{ -} - -static inline int pci_pasid_features(struct pci_dev *pdev) -{ - return -EINVAL; -} - -static inline int pci_max_pasids(struct pci_dev *pdev) -{ - return -EINVAL; -} - -static inline int pci_prg_resp_pasid_required(struct pci_dev *pdev) -{ - return 0; -} -#endif /* CONFIG_PCI_PASID */ - - -#endif /* LINUX_PCI_ATS_H*/ diff --git a/include/linux/pci.h b/include/linux/pci.h index 463486016290..8ac142801890 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2349,6 +2349,40 @@ static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev) void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type); #endif +#ifdef CONFIG_PCI_PRI +int pci_enable_pri(struct pci_dev *pdev, u32 reqs); +void pci_disable_pri(struct pci_dev *pdev); +void pci_restore_pri_state(struct pci_dev *pdev); +int pci_reset_pri(struct pci_dev *pdev); +#else /* CONFIG_PCI_PRI */ +static inline int pci_enable_pri(struct pci_dev *pdev, u32 reqs) +{ return -ENODEV; } +static inline void pci_disable_pri(struct pci_dev *pdev) { } +static inline void pci_restore_pri_state(struct pci_dev *pdev) { } +static inline int pci_reset_pri(struct pci_dev *pdev) +{ return -ENODEV; } +#endif /* CONFIG_PCI_PRI */ + +#ifdef CONFIG_PCI_PASID +int pci_enable_pasid(struct pci_dev *pdev, int features); +void pci_disable_pasid(struct pci_dev *pdev); +void pci_restore_pasid_state(struct pci_dev *pdev); +int pci_pasid_features(struct pci_dev *pdev); +int pci_max_pasids(struct pci_dev *pdev); +int pci_prg_resp_pasid_required(struct pci_dev *pdev); +#else /* CONFIG_PCI_PASID */ +static inline int pci_enable_pasid(struct pci_dev *pdev, int features) +{ return -EINVAL; } +static inline void pci_disable_pasid(struct pci_dev *pdev) { } +static inline void pci_restore_pasid_state(struct pci_dev *pdev) { } +static inline int pci_pasid_features(struct pci_dev *pdev) +{ return -EINVAL; } +static inline int pci_max_pasids(struct pci_dev *pdev) +{ return -EINVAL; } +static inline int pci_prg_resp_pasid_required(struct pci_dev *pdev) +{ return 0; } +#endif /* CONFIG_PCI_PASID */ + /* Provide the legacy pci_dma_* API */ #include <linux/pci-dma-compat.h>
Move ATS function prototypes from include/linux/pci-ats.h to include/linux/pci.h so users only need to include <linux/pci.h>: Realted to PRI capability: pci_enable_pri() pci_disable_pri() pci_restore_pri_state() pci_reset_pri() Related to PASID capability: pci_enable_pasid() pci_disable_pasid() pci_restore_pasid_state() pci_pasid_features() pci_max_pasids() pci_prg_resp_pasid_required() No functional changes intended. Signed-off-by: Krzysztof Wilczynski <kw@linux.com> --- drivers/iommu/amd_iommu.c | 1 - drivers/iommu/arm-smmu-v3.c | 1 - drivers/iommu/intel-iommu.c | 1 - drivers/iommu/intel-pasid.c | 1 - drivers/iommu/intel-svm.c | 1 - drivers/pci/ats.c | 1 - drivers/pci/pci.c | 1 - include/linux/pci-ats.h | 77 ------------------------------------- include/linux/pci.h | 34 ++++++++++++++++ 9 files changed, 34 insertions(+), 84 deletions(-) delete mode 100644 include/linux/pci-ats.h