diff mbox series

ceph: clean up error return in ceph_parse_param

Message ID 20190911163735.23351-1-jlayton@kernel.org (mailing list archive)
State New, archived
Headers show
Series ceph: clean up error return in ceph_parse_param | expand

Commit Message

Jeffrey Layton Sept. 11, 2019, 4:37 p.m. UTC 
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ceph/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ilya, I'm planning to just squash this into the mount API conversion
patch, unless you have objections.

Comments

Ilya Dryomov Sept. 11, 2019, 4:57 p.m. UTC | #1 
On Wed, Sep 11, 2019 at 6:37 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/ceph/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ilya, I'm planning to just squash this into the mount API conversion
> patch, unless you have objections.
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index 5ccaec686eda..2710f9a4a372 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -298,7 +298,7 @@ static int ceph_parse_param(struct fs_context *fc, struct fs_parameter *param)
>                 else if (mode == ceph_recover_session_clean)
>                         fsopt->flags |= CEPH_MOUNT_OPT_CLEANRECOVER;
>                 else
> -                       return -EINVAL;
> +                       goto invalid_value;
>                 break;
>         case Opt_wsize:
>                 if (result.uint_32 < (int)PAGE_SIZE || result.uint_32 > CEPH_MAX_WRITE_SIZE)

No objections, we want the error message.

Thanks,

                Ilya
diff mbox series

Patch

diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index 5ccaec686eda..2710f9a4a372 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -298,7 +298,7 @@  static int ceph_parse_param(struct fs_context *fc, struct fs_parameter *param)
 		else if (mode == ceph_recover_session_clean)
 			fsopt->flags |= CEPH_MOUNT_OPT_CLEANRECOVER;
 		else
-			return -EINVAL;
+			goto invalid_value;
 		break;
 	case Opt_wsize:
 		if (result.uint_32 < (int)PAGE_SIZE || result.uint_32 > CEPH_MAX_WRITE_SIZE)